Skip to content

Commit

Permalink
Merge pull request #111 from scribd/laynax/SERF-1677/rec-mw-kafka
Browse files Browse the repository at this point in the history
[SERF1677] Add sentry recovery to Kafka consumer
  • Loading branch information
laynax authored Jun 20, 2024
2 parents 26b27df + 208a634 commit 91f05cb
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions pkg/pubsub/kafka/partitionconsumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package kafka

import (
"context"
"time"

"github.com/getsentry/sentry-go"
"github.com/twmb/franz-go/pkg/kgo"

sdkkafka "github.com/scribd/go-sdk/pkg/instrumentation/kafka"
Expand All @@ -18,6 +20,14 @@ type pconsumer struct {
}

func (pc *pconsumer) consume(cl *kgo.Client, logger sdklogger.Logger, shouldCommit bool, handler func(*kgo.Record)) {
defer func() {
if rec := recover(); rec != nil {
sentry.CurrentHub().Recover(rec)
sentry.Flush(time.Second * 5)
logger.Fatalf("kafka consumer: panic error: %v", rec)
}
}()

defer close(pc.done)

for {
Expand Down

0 comments on commit 91f05cb

Please sign in to comment.