[SERF-1677] Add recovery middleware for GRPC and HTTP server #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we add a new HTTP middleware and a GRPC interceptor which both serves one purpose, panic recovery in the service endpoint level.
Based on this change, after a panic in an endpoint, the services will:
Fatal
levelTesting considerations
This was tested on go-chassis dev env applying both middlewares.
Sentry events (with both HTTP and GRPC panics) here and datadog logs here
Checklist
development
and/orstaging
README.md
as necessaryRelated links