Fix oneshot adc read waiting indefinitely #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
added a commit
to jannic/rp-hal
that referenced
this pull request
May 3, 2024
jannic
added a commit
to jannic/rp-hal
that referenced
this pull request
May 3, 2024
|
Thanks for finding and fixing this bug! (And sorry for introducing it...) |
jannic
added a commit
to jannic/rp-hal
that referenced
this pull request
May 3, 2024
jannic
added a commit
to jannic/rp-hal
that referenced
this pull request
May 3, 2024
jannic
added a commit
to jannic/rp-hal
that referenced
this pull request
Jul 27, 2024
thejpster
added a commit
that referenced
this pull request
Jul 27, 2024
This adds a test-case covering the fix from PR #799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Adc::readtypically gets stuck in an infinite loop when running inOneShotconfiguration. This bug was introduced in version 0.10 and does not exist on prior versions. It results from theCSregister being read once outside of the wait loop and then never again.