Prevent subscriber tests from hanging forever if no work #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
added a commit
to RoverRobotics-forks/system_tests
that referenced
this pull request
Mar 5, 2020
Backport of ros2#401 Signed-off-by: Dan Rose <[email protected]>
This was referenced Mar 5, 2020
dirk-thomas
reviewed
Mar 6, 2020
Signed-off-by: Dan Rose <[email protected]>
ivanpauno
requested changes
Mar 6, 2020
| @@ -62,7 +62,7 @@ def listener(message_name, namespace): | |||
| spin_count = 1 | |||
| print('subscriber: beginning loop') | |||
| while (rclpy.ok() and len(received_messages) != len(expected_msgs)): | |||
There was a problem hiding this comment.
This condition will still not be met, regardless of spin_once timeout, and this will still be waiting forever (or to the test to timeout). So, changing spin_once behavior from blocking to anything else just makes the loop more busy.
I think the original test case was ok, we can change the timeout of the test to a smaller value to avoid CI taking much longer when some of these tests fail.
|
@rotu friendly ping |
|
Thanks! Yeah, I’m closing this due to user error. I had inferred from the test output that the listener having to be terminated was the problem. Opened #404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Rose [email protected]