Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D] Prevent subscriber tests from hanging forever if no work #402

Closed
wants to merge 1 commit into from
Closed

[D] Prevent subscriber tests from hanging forever if no work #402

wants to merge 1 commit into from

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Mar 5, 2020

Backport of #401
Signed-off-by: Dan Rose [email protected]

@rotu
Copy link
Contributor Author

rotu commented Mar 5, 2020

@joespeed, I suspect this is responsible for many failures in http://build.ros2.org/view/Dci/job/Dci__nightly-extra-rmw-release_ubuntu_bionic_amd64/290/testReport/ that look like test_communication.TestPublisherSubscriber.test_subscriber_terminates_in_a_finite_amount_of_time[...]

@ivanpauno
Copy link
Member

@rotu Thanks for investigating the issue.
Please, avoid to open backport PRs until the original PR is merged.
I'm closing this one, it can be reopened when the discussions in #401 are solved.

@ivanpauno ivanpauno closed this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rotu @ivanpauno