Windows support #58
Windows support #58
Conversation
jacobperron
force-pushed
the
windows_support
branch
from
4245fbb
to
9d71e6f
Compare
| vcs-repo-file-url: > | ||
| https://raw.githubusercontent.com/ros2/ros2/master/ros2.repos |
There was a problem hiding this comment.
Why a specific repos file for Windows?
There was a problem hiding this comment.
Based on the previous failure; I'm pretty sure the ros-tooling actions are not installing any binaries for Windows (like they do for Linux): https://github.com/ros2/domain_bridge/runs/3969771793?check_suite_focus=true
So, I think we need to build everything from source. Please correct me if I'm wrong.
There was a problem hiding this comment.
Ah okay I see. It looks like that didn't work. Here's some discussion that might be relevant: ros-tooling/action-ros-ci#643 (comment)
[edit: Never mind, the CI failure from 7682b0c might be something else. It can't find catkin_pkg now]
There was a problem hiding this comment.
Hmm, I've learned that the setup-ros action supports Windows binaries, just not for Rolling: https://github.com/ros-tooling/setup-ros/blob/c4e8165ee5518c04dc4588bff7c1028ccf563e6f/src/setup-ros-windows.ts#L9-L17
So, I'm thinking for now we only enable Windows CI for the galactic branch, (until ros-tooling/setup-ros#453 is resolved).
For this pull request, I can try running CI from ci.ros2.org infrastructure.
There was a problem hiding this comment.
note that action-ros-ci might not actually properly work for Windows. This PR should apparently fix it though: ros-tooling/action-ros-ci#712
jacobperron
force-pushed
the
windows_support
branch
3 times, most recently
from
db17a54
to
3aa08a8
Compare
|
Windows CI: Edit: we can build on Windows now, but the tests are failing. The output isn't particularly helpful. |
Changes to support building on Windows. - Add missing visibility macros, including CMake target definition - Fix build error passing std::filesystem::path instead of std::string - Fix linker error building against yaml-cpp - Quiet warnings caused by including "yaml-cpp/yaml.h" - Fix build warning in test_domain_bridge.cpp Signed-off-by: Jacob Perron <[email protected]>
This transitively installs yaml-cpp for the target platform. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
force-pushed
the
windows_support
branch
from
3aa08a8
to
05fbdc1
Compare
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
|
Changes to supporting building on Windows (3aa08a8).
Also trying to add Windows CI to the GitHub workflow (db17a54)Closes #57