[roslaunch] Indicating <node> tag when it is actually a <test> tag is confusing. #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130s
force-pushed
the
i/roslaunch/warningmsg
branch
from
d9fdfa0
to
0e1d71b
Compare
dirk-thomas
reviewed
Feb 16, 2017
130s
force-pushed
the
i/roslaunch/warningmsg
branch
3 times, most recently
from
546004d
to
0951eaa
Compare
… confusing. For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)): ``` * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest"> <group unless="$(arg expected_success)"> <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/> <param name="hz" value="0.0"/> </group> ``` This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>. With this PR the message becomes a bit verbose but hope the readers get better idea.
130s
force-pushed
the
i/roslaunch/warningmsg
branch
from
0951eaa
to
58cf7ad
Compare
|
Thank you for the patch. I cherry-picked a slightly modified version ("child %s tag" -> "%s child tag") in 084b51b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this warning msg (in this PR):
This is confusing because the tag in question is actually
<test>, not<node>. Although the warning message refers to the exact tag, I didn't try to read it because I was told the issue is with<node>, not<test>.With this PR the message becomes a bit verbose but hope the readers get better idea.