Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added compatibility with Boost 1.72.0 #221

Open
wants to merge 1 commit into
base: melodic-devel
Choose a base branch
from
Open

added compatibility with Boost 1.72.0 #221

wants to merge 1 commit into from

Conversation

davidfreina
Copy link

see issue #220 for further clarification

tfoote
tfoote requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the documentation it looks to me like INCLUDE_DIRS might be better than INCLUDEDIR

It looks like INCLUDE_DIRS is for downatream usage
https://discourse.cmake.org/t/findboost-difference-between-boost-include-dir-and-boost-include-dirs/855/2

Oldest supported cmake version says INCLUDEDIR is a hint not the same as the export.
https://cmake.org/cmake/help/v3.5/module/FindBoost.html

And the latest version of cmake still has the find boost showing INCLUDE_DIR as active: https://cmake.org/cmake/help/v3.20/module/FindBoost.html

Can you please provide documentation as to why you think that this is the right fix? And what has changed that caused a breakage now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfreina @tfoote