Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gz-physics#283 to implement joint_states/effort feedback #186

Open
wants to merge 2 commits into
base: jazzy
Choose a base branch
from

Conversation

andreasBihlmaier
Copy link

@andreasBihlmaier andreasBihlmaier commented Oct 7, 2023

Fixes joint_states/effort being zero for joints with <state_interface name="effort" /> in combination with joint_state_broadcaster/JointStateBroadcaster by using the JointTransmittedWrench component introduced by gazebosim/gz-physics#283.

The joint axis is hard coded to z. I did not yet look into reading out the actual <axis> of the joint and extracting the respective force/torque component of the wrench.

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Two comments:

  • Can you review linters?
  • can you add a comment related to the hardcoded z joint ? or do you plan to continue working on this PR ?

@Nemantor
Copy link

I tried it and it works properly, couldn't find any problems

@azeey azeey mentioned this pull request May 20, 2024
@christophfroehlich christophfroehlich linked an issue May 21, 2024 that may be closed by this pull request
@BarisYazici
Copy link

We are currently integrating Gazebo and would like to have the efforts from simulation. How is this PR going?

@andreasBihlmaier
Copy link
Author

I'll take a quick look this weekend whether I can get this PR cleaned up and submitted.

@andreasBihlmaier
Copy link
Author

This should do it (further testing strongly recommended): andreasBihlmaier@59ef8f0

I'll try to either update this PR or create a new one in the next days.

@andreasBihlmaier andreasBihlmaier changed the base branch from humble to jazzy June 16, 2024 19:59
@andreasBihlmaier
Copy link
Author

I did a bit of quick testing wrsp to joint axis. The effort seems to be reported as expected.
I force pushed https://github.com/andreasBihlmaier/gz_ros2_control/tree/fix-effort-state-jazzy onto the fix-effort-state branch (GitHub does not allow to change PR source branches) and retargeted this PR to jazzy branch.

@BarisYazici
Copy link

I tested this. It works for us. Thanks a lot @andreasBihlmaier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effort Values are 0
4 participants