Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic changes #100

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

cosmetic changes #100

wants to merge 1 commit into from

Conversation

dbscoach
Copy link
Contributor

Signed-off-by: David Schwarz [email protected]

Please describe your change in one or two sentences

I have some cosmetic edits to the rules document that I want to queue up.

Please explain why do you think this change should be in the rules

Just housekeeping. Will un-draft PR as they are done.

@mrshu
Copy link
Contributor

mrshu commented Aug 16, 2023

@dbscoach I presume we'd want to get these in at some point?

@mrshu
Copy link
Contributor

mrshu commented Dec 6, 2023

@dbscoach I guess this is no longer relevant, right?

@dbscoach
Copy link
Contributor Author

I maintain that we'll need a bit of a rewrite of the rules at some point for readability and to remove some of the idiosyncrasies we don't even notice anymore because these have been the rules forever. I had started to make a couple edits here and there and still think those would be worthwhile but lost track of that over the past year. I'd like to keep the PR open to rebase and revive that effort hopefully in Q1 of 2024

@mrshu
Copy link
Contributor

mrshu commented Dec 13, 2023

Thanks @dbscoach, that sounds very reasonable. I just wasn't sure whether this was something worth closing but it doesn't seem like it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants