Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added draft probes.ts file in e2e directory #3161

Open
wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

Added draft probes.ts file in e2e directory #3161

wants to merge 6 commits into from

Commits on Sep 30, 2024

  1. Added draft probes.ts file in e2e directory as per issue 

    responsible-ai-collaborative#2886

The probe tests in probes.ts use the (new) pages-tests.ts/testUrls
utility function (which is a generalized version of the previous
pages-tests.ts/testPages.

I've tried to have these tests be somewhat similar to the tests in
pages?.spec.ts.  Someone may want to refactor the tests for organization
and desired consistency, I'm +1 for any renaming/refactoring/etc that is
desired.

I don't know how/when it's desired to run these tests, and so need to
consult with team about that before changing the config and/or github
actions appropriately.  This is
    @scottslewis
    scottslewis committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1e79b19 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Refactoring of probes.ts based upon input from issue 

    responsible-ai-collaborative#2886
    @scottslewis
    scottslewis committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    199ddae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'responsible-ai-collaborative:staging' into staging

    @scottslewis
    scottslewis authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    927f3e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Additional refactoring of probes.ts 

    based upon input from issue

responsible-ai-collaborative#2886
    @scottslewis
    scottslewis committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    098988f View commit details
    Browse the repository at this point in the history

  2. Removed e2e/probes

    @scottslewis
    scottslewis committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e898905 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Updated probes array so that each path is run as a separate test

    @scottslewis
    scottslewis committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7aaf429 View commit details
    Browse the repository at this point in the history