Added draft probes.ts file in e2e directory #3161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
responsible-ai-collaborative#2886 The probe tests in probes.ts use the (new) pages-tests.ts/testUrls utility function (which is a generalized version of the previous pages-tests.ts/testPages. I've tried to have these tests be somewhat similar to the tests in pages?.spec.ts. Someone may want to refactor the tests for organization and desired consistency, I'm +1 for any renaming/refactoring/etc that is desired. I don't know how/when it's desired to run these tests, and so need to consult with team about that before changing the config and/or github actions appropriately. This is
based upon input from issue responsible-ai-collaborative#2886
kepae
reviewed
Oct 18, 2024
| paths: ['/apps/checklist/'] | ||
| } | ||
| ].forEach(({title, baseUrl, paths}) => { | ||
| test(title, () => testUrls(baseUrl, paths)); |
There was a problem hiding this comment.
Just checking: I believe testUrls() will run nested Playwright tests. What does the output of this test look like?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added draft probes.ts file in e2e directory as per issue
#2886