Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAE technologies and their parameters #1741

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

katarkow
Copy link
Contributor

Purpose of this PR

Adding OAE (ocean alkalinity enhancement) technologies to all_te to generate new input data with OAE. A PR to add it as a CDR option will follow.

Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please aso run make test to besure that everyting is working

@katarkow
Copy link
Contributor Author

katarkow commented Jul 15, 2024

image @LaviniaBaumstark

mix0 0 0
eta 1.00 1.00
omf 0.84 0.025
inco0 0.01 18800 200 400
Copy link
Contributor

@strefler strefler Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should inco0 not be converted to USD/tC from USD/tCaO as calculated below? And why is inco0 for DACCS a factor of 100 higher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, but this inco0 is converted inside the code as the cost USD/tC depends on efficiency which a user can set. The capex is only 15$/tCaO, hence the difference between OAE and DACCS. You can see the calculations below in the same file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you give an example of an efficiency, or even better the whole range we use, so that one can follow these conversions and compare them with DAC?

@LaviniaBaumstark
Copy link
Member

I think, this can be merged. right @strefler @katarkow ?

@katarkow
Copy link
Contributor Author

Almost :) let me just update the input data version and test it quickly and I'll merge it

@katarkow
Copy link
Contributor Author

Change of plans, I will merge this first and then update the input data version in a separate PR, as some little fixes are need for that input data to work

@katarkow katarkow merged commit 19dd9fc into remindmodel:develop Jul 25, 2024
2 checks passed
@katarkow katarkow deleted the OAE_data_tech branch July 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants