Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAE capacity factors #521

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add OAE capacity factors #521

merged 1 commit into from
Jul 24, 2024

Conversation

katarkow
Copy link
Contributor

@katarkow katarkow commented Jul 12, 2024

This PR adds capacity factors of OAE (ocean alkalinity enhancement) technologies. To be merged after REMIND#1741. The new source file can be found here: /p/projects/rd3mod/inputdata/sources/REMIND_11Regi/f_cf-global_REMIND_3.3.5.csv.

Changes in f_cf-global_REMIND_3.3.5.csv from the previous f_cf-global_REMIND_3.3.4.csv:
+oae_ng;0.8
+oae_el;0.8
rockgrindweathering;0.69

"deltacapoffset" = read.csv("p_adj_deltacapoffset.csv", sep = ";") %>% as.magpie(datacol = 2),
"capacityFactorGlobal" = {
x <- read.csv("f_cf-global_REMIND_3.3.4.csv", sep = ";")
x[x$Tech == "rockgrind", "Tech"] <- "weathering"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed rockgrind to weathering in the new source file.

Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are this new data in this very old source folder? All data from this folder should be substituted by later data where ever possible. Maybe it should go into "ExpertGuess" ?

@katarkow
Copy link
Contributor Author

Hi Lavinia! I used the same place where the original data has been, and besides the last time that input data was updated was May 21st of this year. Should the capacity factors be migrated to ExpertGuess? @LaviniaBaumstark @fbenke-pik

@LaviniaBaumstark
Copy link
Member

o.k., than go for it now as it is and we will clean up REMIND_11regi later

@LaviniaBaumstark
Copy link
Member

@strefler what about this PR?

@katarkow katarkow requested a review from strefler July 24, 2024 13:11
@katarkow katarkow merged commit 1b59beb into pik-piam:master Jul 24, 2024
2 checks passed
@katarkow katarkow deleted the OAE_f_cf branch July 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants