Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow appeding to cfg$output via scenario_config.csv; allow setting output also for coupled runs; update comments #1575

Merged
merged 10 commits into from
Feb 27, 2024

Conversation

dklein-pik
Copy link
Contributor

@dklein-pik dklein-pik commented Feb 23, 2024

Purpose of this PR

Fixes #1451 and closes remindmodel/development_issues/issues/247

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@dklein-pik dklein-pik changed the title Small fix, update comments Allow appeding to cfg$output via scenario_config.csv; allow setting output also for coupled runs; update comments Feb 27, 2024
Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope nobody gets confused later why once unlist and once [[1]] is used, but that might be a minor detail. Thanks for fixing it.

@dklein-pik
Copy link
Contributor Author

Hope nobody gets confused later why once unlist and once [[1]] is used, but that might be a minor detail. Thanks for fixing it.

Harmonized this.

@dklein-pik dklein-pik merged commit 19c7b4b into remindmodel:develop Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying cfg$output does not work for coupled runs
2 participants