Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying cfg$output does not work for coupled runs #1451

Closed
orichters opened this issue Nov 2, 2023 · 1 comment · Fixed by #1575
Closed

Specifying cfg$output does not work for coupled runs #1451

orichters opened this issue Nov 2, 2023 · 1 comment · Fixed by #1575
Assignees
Labels
bug Something isn't working

Comments

@orichters
Copy link
Contributor

orichters commented Nov 2, 2023

I just noticed that if you specify output in your scenario_config file which is mapped to cfg$output for standalone runs in configureCfg, that does not work in a coupled run. Also means it does not work in the short cascade of the model tests. There is simply no code in start_bundle_coupled.R that does it.

Which makes me think whether we should adjust start_bundle_coupled.R such that it also calls configureCfg to avoid repeating code (of course, that might need some adjustments here and there).

Actually unrelated, but I would like to have this feature: Specify cfg$output,fixOnRef in the output column, and then the scripts adds fixOnRef to the output scripts defined in default.cfg. Should not be that difficult.

@dklein-pik
Copy link
Contributor

dklein-pik commented Feb 23, 2024

I will close this issue with PR #1575 but find your ideas useful regarding configureCfg and cfg$output,fixOnRef and move them to new issues in development_issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants