Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove four asterisks in code comments (reserved for GAMS error messages) #1571

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

aodenweller
Copy link
Contributor

@aodenweller aodenweller commented Feb 21, 2024

Purpose of this PR

Sequences of four asterisks are reserved for GAMS error messages, but were inserted in code comments in cede734, bace67b and 06f746c. This replaces them.

Type of change

Only changing comments, not code.

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@aodenweller aodenweller added the minor minor issue, not urgent label Feb 21, 2024
@cchrisgong
Copy link
Contributor

Thanks! Was gonna submit one today.. you beat me to it :P

@aodenweller aodenweller merged commit 5d56d95 into remindmodel:develop Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor issue, not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants