Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use newest gms in github action; fail on codeCheck warning; test that no line starts with **** #1579

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Feb 26, 2024

Purpose of this PR

Failure:

-- Testing test_99-codeCheck.R ---------------------------------------------------
[ FAIL 1 | WARN 1 | SKIP 0 | PASS 1 ]

-- Warning (test_99-codeCheck.R:25:7): No four asterisks in code ---------------
The following lines start with four asterisks, reserved for GAMS error messages.
../../core/datainput.gms:**** |  (C) 2006-2023 Potsdam Institute for Climate Impact Research (PIK)

-- Failure (test_99-codeCheck.R:28:5): No four asterisks in code ---------------
length(starlines) == 0 is not TRUE

`actual`:   FALSE
`expected`: TRUE
[ FAIL 1 | WARN 1 | SKIP 0 | PASS 1 ]

grep not available:

-- Testing test_99-codeCheck.R ----------------------------------------------------------------------
[ FAIL 0 | WARN 0 | SKIP 1 | PASS 1 ]

-- Skipped tests (1) ------------------------------------------------
• 'grep' not available, please check yourself whether code starts with four asterisks. (1): test_99-codeCheck.R:19:5

Everything fine:

-- Testing test_99-codeCheck.R ----------------------------------------------------------------------
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 2 ] Done!

Type of change

  • Bug fix

Checklist:

  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test) [ FAIL 0 | WARN 0 | SKIP 6 | PASS 82 ]

@orichters orichters changed the title always load newest gms from pik-piam for github action in github action, use newest gms::codeCheck, fail on codeCheck warnings Feb 27, 2024
@orichters orichters marked this pull request as ready for review February 27, 2024 07:52
@orichters orichters changed the title in github action, use newest gms::codeCheck, fail on codeCheck warnings use newest gms in github action; fail on codeCheck warning; test that no line starts with **** Feb 27, 2024
@orichters orichters merged commit af3eee7 into remindmodel:develop Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants