Use rapids-dependency-file-generator #17
Conversation
There was a problem hiding this comment.
Thanks Kyle, this is really great work. It's definitely proof that this integration is possible and is moving us in the right direction. I do think there are some key design issues that we need to address around the rbb/dfg interface before we can get further, particularly around improving dfg's API to support rbb and figuring out what's going to be responsible for producing and appending the alpha version specifiers.
| make_dependency_files(parsed_config, config.dependencies_file, False) | ||
| pyproject = utils._get_pyproject() | ||
| project_data = pyproject["project"] | ||
| project_data["name"] += _get_cuda_suffix(config.require_cuda) |
There was a problem hiding this comment.
This still needs to obey the disable_cuda_suffix config.
There was a problem hiding this comment.
The old version did not obey disable_cuda_suffix - that was only when transforming the dependencies.
There was a problem hiding this comment.
I think we are going to want the ability to turn on and off the suffix for the package as well. However, this PR is pretty well-scoped right now so let's put a pin in this question, get the PR merged, and then come back to address it. The use-case where I think this will matter is devcontainers (or more generally in integrated dev environments where things are being built from source). We'll just need to ensure consistency.
| make_dependency_files(parsed_config, config.dependencies_file, False) | ||
| pyproject = utils._get_pyproject() | ||
| project_data = pyproject["project"] | ||
| project_data["name"] += _get_cuda_suffix(config.require_cuda) |
There was a problem hiding this comment.
I think we are going to want the ability to turn on and off the suffix for the package as well. However, this PR is pretty well-scoped right now so let's put a pin in this question, get the PR merged, and then come back to address it. The use-case where I think this will matter is devcontainers (or more generally in integrated dev environments where things are being built from source). We'll just need to ensure consistency.
Rather than modifying the dependencies, we should delegate the handling of dependencies to DFG. Call out to DFG's newly-stable Python API to modify
pyproject.toml.