chore(refactor): require keyword-only args in make_dependency_files() #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
KyleFromNVIDIA
approved these changes
May 13, 2024
|
thanks @KyleFromNVIDIA ! |
|
🎉 This PR is included in version 1.13.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31.
Follow-up to rapidsai/rapids-build-backend#17 (comment).
Proposes restricting
make_dependency_files()to only accepting keyword arguments, to reduce the risk of oops-passed-this-in-the-wrong-order types of bugs, and to make code using it a little bit easier to read.Notes for Reviewers
The only direct usage of that function outside of this project itself is in
rapids-build-backend, and that's already using keyword arguments in its one call (GitHub search | rapids-build-backend code link).So this is safe to merge and shouldn't break anything.