Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kafka version in template for strimzi operator. #852

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Aug 8, 2023

Summary

Hi, this PR fixing OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT which was failing because the 3.3.1 was not supported version. See this log:

Unsupported Kafka.spec.kafka.version: 3.3.1. Supported versions are: [3.4.0, 3.4.1, 3.5.0, 3.5.1]

So it's never started and timed out.

Maybe the update of version here should be done as well but tests are not failing so there is probably no need for that.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 requested a review from mjurc August 8, 2023 15:19
@jedla97
Copy link
Member Author

jedla97 commented Aug 8, 2023

run tests

@mjurc
Copy link
Member

mjurc commented Aug 9, 2023

My bad, the PR passed.

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@mjurc mjurc merged commit c5956a1 into quarkus-qe:main Aug 9, 2023
5 checks passed
@jedla97 jedla97 deleted the fix-ocp-kafka branch April 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants