Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return random off topic names which are Active only #644

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Return random off topic names which are Active only #644

merged 4 commits into from
Feb 16, 2022

Conversation

RohanJnr
Copy link
Member

Background

Changes

  • This PR filters the off topic channels names and only sends the active names as response to an incoming GET request to bot/off-topic-channel-names?random_items=x
  • Test cases were modified which were relevant to the above change.

@netlify
Copy link

netlify bot commented Jan 23, 2022 •
edited
Loading

✔️ Deploy Preview for pydis-static ready!

🔨 Explore the source changes: 01fdd39

🔍 Inspect the deploy log: https://app.netlify.com/sites/pydis-static/deploys/620d6b7630365800076e365c

😎 Browse the preview: https://deploy-preview-644--pydis-static.netlify.app

@coveralls
Copy link

coveralls commented Jan 23, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 01fdd39 on otn_active_only into 4196696 on main.

@RohanJnr RohanJnr mentioned this pull request Jan 23, 2022
Merged
jchristgit
jchristgit approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Rohan! Concise and tested. Excellent!

@Xithrius Xithrius requested review from jchristgit and jb3 and removed request for jchristgit January 31, 2022 21:36
Xithrius
Xithrius reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am not confident in my abilities on site. We shall wait for another person approves.

@Xithrius Xithrius added area: API Related to or causes API changes area: backend Related to internal functionality and utilities priority: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features labels Jan 31, 2022
@jchristgit jchristgit requested review from ks129 and jb3 and removed request for jb3 February 1, 2022 21:10
Xithrius
Xithrius approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@Xithrius Xithrius enabled auto-merge (squash) February 16, 2022 21:24
@Xithrius Xithrius merged commit 15cac33 into main Feb 16, 2022
@Xithrius Xithrius deleted the otn_active_only branch February 16, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xithrius Xithrius Xithrius approved these changes

@jchristgit jchristgit jchristgit approved these changes

@ks129 ks129 Awaiting requested review from ks129

@jb3 jb3 Awaiting requested review from jb3

@MarkKoz MarkKoz Awaiting requested review from MarkKoz

Assignees
No one assigned
Labels
area: API Related to or causes API changes area: backend Related to internal functionality and utilities priority: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RohanJnr @coveralls @Xithrius @jchristgit