Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reroll command. #1568

Merged
merged 19 commits into from
Jun 13, 2022
Merged

Add reroll command. #1568

merged 19 commits into from
Jun 13, 2022

Conversation

RohanJnr
Copy link
Member

@RohanJnr RohanJnr commented May 6, 2021 •
edited
Loading

closes #1559

Note

This PR is linked to changes made in python-discord/site#644

Changes

  • Added off topic reroll command to reroll the current off topic channel name for a new one and also de-activates/blacklists it (It won't be used for future off topic channel names).
  • Added commands to activate and deactivate a command.
  • Added commands to list active and inactive off topic channel names.
  • In case of a rate limit during the reroll command (while the bot is renaming the channel), the user is prompted whether they want to schedule a channel rename process (handled by dpy).
  • Rate limits: A channel can be renamed twice within 10minutes.

image

@RohanJnr
Add reroll command plus additional format changes.
ef44975 
Use format strings to generate off-topic channel name.
Abstract delete command code into a separate method.
ToxicKidz
ToxicKidz previously requested changes May 6, 2021
View reviewed changes
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
@RohanJnr
Copy link
Member Author

RohanJnr commented May 6, 2021

Its still draft 😬 but thanks for reviews.

@Xithrius Xithrius added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: frontend Related to output and formatting p: 2 - normal Normal Priority s: WIP Work In Progress t: feature New feature or request labels May 7, 2021
@jb3
Copy link
Member

jb3 commented May 9, 2021

Correct me if I'm wrong, but in the staff meeting didn't we decide that we should not delete but instead mark a name as "out of circulation", if so, this will require an additional site PR.

@Xithrius Xithrius added p: 3 - low Low Priority and removed p: 2 - normal Normal Priority labels Jun 8, 2021
@Xithrius
Copy link
Member

Xithrius commented Jun 9, 2021

Correct me if I'm wrong, but in the staff meeting didn't we decide that we should not delete but instead mark a name as "out of circulation", if so, this will require an additional site PR.

@jb3 I'm pretty sure that's what we decided. How should we approach this site PR?

@jb3
Copy link
Member

jb3 commented Jun 9, 2021

There are some backend changes for this at python-discord/site#490

@RohanJnr RohanJnr mentioned this pull request Jun 9, 2021
Merged
@Numerlor Numerlor mentioned this pull request Jun 14, 2021
Closed
@Xithrius Xithrius added s: stalled Something is blocking further progress and removed s: WIP Work In Progress a: frontend Related to output and formatting labels Aug 31, 2021
@Xithrius Xithrius added s: waiting for author Waiting for author to address a review or respond to a comment and removed s: stalled Something is blocking further progress labels Dec 28, 2021
@RohanJnr
Copy link
Member Author

@Bluenix2 it is now. Updated PR description.

@RohanJnr RohanJnr added a: fun Related to non-serious, "fun" features (duck pond, off topic channel names) and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Jan 24, 2022
Bluenix2
Bluenix2 reviewed Jan 25, 2022
View reviewed changes
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
@Xithrius Xithrius requested review from lemonsaurus and removed request for ks129 February 13, 2022 20:54
@Xithrius
Copy link
Member

Xithrius commented Feb 16, 2022 •
edited
Loading

@RohanJnr What is your status on this PR?

Bluenix2
Bluenix2 reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@Bluenix2 Bluenix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, just needs to address one comment I have!

bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
@Bluenix2 Bluenix2 added the s: waiting for author Waiting for author to address a review or respond to a comment label Mar 8, 2022
@RohanJnr RohanJnr requested a review from Bluenix2 March 9, 2022 16:29
Bluenix2
Bluenix2 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@Bluenix2 Bluenix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I did have one cosmetic comment, but it does not affect my review.

Thank you for finishing this PR after it was stalled/delayed! ❤️

bot/exts/fun/off_topic_names.py Outdated Show resolved Hide resolved
@RohanJnr @Bluenix2
Update bot/exts/fun/off_topic_names.py
c5d89b3 
Format code

Co-authored-by: Bluenix <[email protected]>
@Bluenix2 Bluenix2 added s: needs review Author is waiting for someone to review and approve and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Mar 18, 2022
@Xithrius Xithrius requested review from wookie184 and bast0006 and removed request for lemonsaurus May 27, 2022 21:47
wookie184
wookie184 approved these changes May 28, 2022
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the conflicts are resolved, I think this is ready to merge 🤞

@ChrisLovering ChrisLovering added s: waiting for author Waiting for author to address a review or respond to a comment and removed s: needs review Author is waiting for someone to review and approve labels Jun 7, 2022
@Xithrius Xithrius merged commit 61f25af into python-discord:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anand2312 anand2312 anand2312 left review comments

@ToxicKidz ToxicKidz ToxicKidz left review comments

@wookie184 wookie184 wookie184 approved these changes

@Bluenix2 Bluenix2 Bluenix2 approved these changes

@ChrisLovering ChrisLovering Awaiting requested review from ChrisLovering

@jb3 jb3 Awaiting requested review from jb3

@Xithrius Xithrius Awaiting requested review from Xithrius

@bast0006 bast0006 Awaiting requested review from bast0006

Assignees
No one assigned
Labels
a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: fun Related to non-serious, "fun" features (duck pond, off topic channel names) p: 3 - low Low Priority s: waiting for author Waiting for author to address a review or respond to a comment t: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a delete and reroll command for OT names
8 participants
@RohanJnr @jb3 @Xithrius @Bluenix2 @wookie184 @anand2312 @ToxicKidz @ChrisLovering