Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable summary method for all currently implemented frequentist experiments #355

Merged
merged 10 commits into from
Jun 19, 2024

Conversation

drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent commented Jun 14, 2024

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbenvincent drbenvincent added documentation Improvements or additions to documentation enhancement New feature or request outputs Quantitative outputs of the model labels Jun 14, 2024
@drbenvincent drbenvincent added this to the 0.3.1 milestone Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (4af4af6) to head (9fc0798).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   79.96%   80.87%   +0.91%     
==========================================
  Files          21       21              
  Lines        1642     1668      +26     
==========================================
+ Hits         1313     1349      +36     
+ Misses        329      319      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

review-notebook-app bot commented Jun 19, 2024

View / edit / reply to this conversation on ReviewNB

juanitorduz commented on 2024-06-19T08:00:38Z
----------------------------------------------------------------

These numbers look in different columns. Why don't er print a dataframe?


@juanitorduz
Copy link
Collaborator

Some tables based on print statements look out of phase. What if we use something like in the pyfixest package https://py-econometrics.github.io/pyfixest/quickstart.html ?

@drbenvincent
Copy link
Collaborator Author

drbenvincent commented Jun 19, 2024

Some tables based on print statements look out of phase.

Very good point @juanitorduz . For the moment I've kept the same basic approach, but have improved the formatting. The function that prints the model coefficients now evaluates the length of the longest coefficient label so that it can align the coefficient values appropriately.

I'm very open to rethinking the nature of the summary outputs, but I'm tempted to deal with that in a separate issue. For example, there is already #174 as one option.

I'll do a similar formatting improvement for the pymc experiments in a different issue now.

What do you think?

PS. I just noticed I probably have to update the doctests 🤣 Will do that now :)

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! let's follow up the next iteration on the associated issue :)

@drbenvincent drbenvincent merged commit 2916688 into main Jun 19, 2024
8 checks passed
@drbenvincent drbenvincent deleted the summary branch June 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request outputs Quantitative outputs of the model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC + ITS: quantitative outputs
2 participants