Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of model coefficients in summary method in pymc-based experiments #359

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent commented Jun 19, 2024

Similar to an improvement made in #355 to the summary method in scikit-learn based experiments, but for the pymc based experiments.

Printing of the model coefficients is now better horizontally aligned. The position of the coefficient values is now governed by the width of the longest coefficient label string.

I also re-ran the pymc based notebooks so that we get the updated summary output in the docs.


📚 Documentation preview 📚: https://causalpy--359.org.readthedocs.build/en/359/

@drbenvincent drbenvincent added the enhancement New feature or request label Jun 19, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbenvincent drbenvincent added this to the 0.3.1 milestone Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (2916688) to head (267d7c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   80.87%   83.10%   +2.23%     
==========================================
  Files          21       21              
  Lines        1668     1687      +19     
==========================================
+ Hits         1349     1402      +53     
+ Misses        319      285      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drbenvincent drbenvincent merged commit 9330a9c into main Jun 19, 2024
7 checks passed
@drbenvincent drbenvincent deleted the summary_pymc branch June 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants