Logprob derivation for Max of continuous IID variables #6769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6769 +/- ##
==========================================
+ Coverage 89.15% 92.05% +2.90%
==========================================
Files 95 96 +1
Lines 16324 16373 +49
==========================================
+ Hits 14553 15072 +519
+ Misses 1771 1301 -470
|
ricardoV94
reviewed
Jun 11, 2023
pymc/logprob/order.py
Outdated
|
|
||
|
|
||
| class MeasurableMax(MaxAndArgmax): | ||
| """A placeholder used to specify a log-likelihood for a clipped RV sub-graph.""" |
There was a problem hiding this comment.
Suggested change
| """A placeholder used to specify a log-likelihood for a clipped RV sub-graph.""" | |
| """A placeholder used to specify a log-likelihood for a max sub-graph.""" |
ricardoV94
reviewed
Jun 11, 2023
There was a problem hiding this comment.
Great progress @Dhruvanshu-Joshi! Some comments to complement @ricardoV94's review
Dhruvanshu-Joshi
force-pushed
the
dev-order_stats
branch
from
73fd883
to
2b6181a
Compare
5 tasks
ricardoV94
reviewed
Jun 23, 2023
ricardoV94
reviewed
Jun 23, 2023
ricardoV94
reviewed
Jun 23, 2023
ricardoV94
reviewed
Jun 23, 2023
ricardoV94
reviewed
Jun 23, 2023
ricardoV94
reviewed
Jun 23, 2023
ricardoV94
reviewed
Jun 29, 2023
There was a problem hiding this comment.
Great progress @Dhruvanshu-Joshi! Slight comments about the documentation on my side
Dhruvanshu-Joshi
force-pushed
the
dev-order_stats
branch
from
97911de
to
9759720
Compare
ricardoV94
requested changes
Jul 4, 2023
ricardoV94
reviewed
Jul 15, 2023
ricardoV94
reviewed
Jul 15, 2023
ricardoV94
previously approved these changes
Jul 17, 2023
|
Remind me what's pending for merging this PR? |
|
I think it just needs to be rebased so the tests pass. There was an unrelated failure that crop up elsewhere |
Dhruvanshu-Joshi
force-pushed
the
dev-order_stats
branch
from
9f9f16b
to
7e79bfa
Compare
Dhruvanshu-Joshi
force-pushed
the
dev-order_stats
branch
from
93c5051
to
8bf0154
Compare
ricardoV94
approved these changes
Jul 27, 2023
ricardoV94
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR aims to provide a solution for implementing the Max operation from order statistics to solve the issue [#6350] (#6350) and issue #6773. More tests are to be added.
Checklist
Major / Breaking Changes
New features
pt.maxBugfixes
To-do:
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6769.org.readthedocs.build/en/6769/