Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev order min #6836

Closed
Closed

Conversation

Dhruvanshu-Joshi
Copy link
Member

@Dhruvanshu-Joshi Dhruvanshu-Joshi commented Jul 23, 2023

What is this PR about?
This PR aims to provide a solution for implementing the Max operation from order statistics to solve the issue #6350 and issue 6773. This is an extension of #6769. More tests related to MIN operation are to be added.

Checklist

Major / Breaking Changes

  • ...

New features

  • Logprob derivation for pt.min

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

📚 Documentation preview 📚: https://pymc--6836.org.readthedocs.build/en/6836/

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #6836 (994ffec) into main (5c600c7) will decrease coverage by 4.54%.
The diff coverage is 31.86%.

❗ Current head 994ffec differs from pull request most recent head 4ddddc8. Consider uploading reports for the commit 4ddddc8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6836      +/-   ##
==========================================
- Coverage   92.03%   87.50%   -4.54%     
==========================================
  Files          96       96              
  Lines       16378    16413      +35     
==========================================
- Hits        15074    14362     -712     
- Misses       1304     2051     +747     
Files Changed Coverage Δ
pymc/logprob/transforms.py 67.36% <ø> (-27.33%) ⬇️
pymc/logprob/order.py 29.54% <29.54%> (-68.33%) ⬇️
pymc/logprob/__init__.py 100.00% <100.00%> (ø)
pymc/logprob/rewriting.py 80.00% <100.00%> (-10.00%) ⬇️

... and 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant