Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTING Feature/590 add skill #611

Merged
merged 16 commits into from
Mar 15, 2024
Merged

TESTING Feature/590 add skill #611

merged 16 commits into from
Mar 15, 2024

Conversation

kcinay055679
Copy link
Collaborator

No description provided.

@kcinay055679 kcinay055679 marked this pull request as ready for review February 23, 2024 11:03
@kcinay055679 kcinay055679 linked an issue Feb 23, 2024 that may be closed by this pull request
New-Skills: Add Skill in Skillset #590
Closed
Robin481
Robin481 previously requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Small adjustments and then merge time 🚀

app/controllers/skills_controller.rb Outdated Show resolved Hide resolved
spec/features/skills_form_spec.rb Outdated Show resolved Hide resolved
spec/features/skills_form_spec.rb Show resolved Hide resolved
spec/controllers/skills_controller_spec.rb Outdated Show resolved Hide resolved
@kcinay055679 kcinay055679 dismissed Robin481’s stale review February 26, 2024 10:21

all requested change are implemented

@kcinay055679 kcinay055679 force-pushed the feature/590-add-skill branch 2 times, most recently from a06f6a0 to 1fce74a Compare March 15, 2024 12:26
@Robin481 Robin481 force-pushed the feature/590-add-skill branch 2 times, most recently from c981487 to 1fce74a Compare March 15, 2024 13:16
Robin481
Robin481 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Robin481 Robin481 merged commit 3f6c69b into master Mar 15, 2024
2 checks passed
@Robin481 Robin481 deleted the feature/590-add-skill branch March 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin481 Robin481 Robin481 approved these changes

Assignees

@Robin481 Robin481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New-Skills: Add Skill in Skillset
2 participants
@kcinay055679 @Robin481