Skip to content

Commit

Permalink
implemnt review
Browse files Browse the repository at this point in the history
  • Loading branch information
kcinay055679 committed Feb 26, 2024
1 parent a5ca54f commit 8f8ac91
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/controllers/skills_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
class SkillsController < CrudController
include ExportController

# before_action :authorize_admin, except: %i[index show create unrated_by_person]

self.permitted_attrs = %i[title radar portfolio default_set category_id]

def create
Expand Down
10 changes: 10 additions & 0 deletions spec/features/skills_form_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,17 @@
select @radar, from: 'skill_radar'
select @portfolio, from: 'skill_portfolio'
click_button 'Skill erstellen'
click_button 'Skill erstellen'
all 'tbody tr', count: 6
# Check for the skill names instead of the amount
within('tbody') do
expect(page).to have_content('Bash')
expect(page).to have_content('cunit')
expect(page).to have_content('ember')
expect(page).to have_content('JUnit')
expect(page).to have_content('Rails')
expect(page).to have_content('New Skill Title')
end
end

it 'displays error messages when present' do
Expand Down

0 comments on commit 8f8ac91

Please sign in to comment.