Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back user profile #599

Merged
merged 80 commits into from
Mar 15, 2024
Merged

Bring back user profile #599

merged 80 commits into from
Mar 15, 2024

Commits on Mar 12, 2024

  1. add first tables to display profile data

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f8a73a1 View commit details
    Browse the repository at this point in the history

  2. add language and profile pic to view and add a new section in the vie… 

    …w respectively. make roles display correctly
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8da7aad View commit details
    Browse the repository at this point in the history

  3. style headers of user profile data table and move edit link

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0414a9a View commit details
    Browse the repository at this point in the history

  4. display languages in a very basic way

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fd6458b View commit details
    Browse the repository at this point in the history

  5. make account overview display country name instead of alpha2 code and… 

    … implement most of the edit form to edit a user-profile
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    86d149c View commit details
    Browse the repository at this point in the history

  6. fix displaying of values in dropdowns, to represent actual state of o… 

    …bject and add fields for percentage and level
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bdd96ac View commit details
    Browse the repository at this point in the history

  7. label role form fields and correctly display role in overview

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5a90a03 View commit details
    Browse the repository at this point in the history

  8. replace @entry with @person after rebase and remove nested_models and… 

    … permitted_relationships from people controller
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7d49266 View commit details
    Browse the repository at this point in the history

  9. move edit form to edit route and add turbo frame that loads edit form… 

    … in overview when edit is clicked and remove absolute width from account overview tables
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6feae9f View commit details
    Browse the repository at this point in the history

  10. fix alignment of tables, set width of input fields to match table wid… 

    …th, add save button and fix saving of form
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a2a154e View commit details
    Browse the repository at this point in the history

  11. style edit form to use bootstrap form fields

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    46055cb View commit details
    Browse the repository at this point in the history

  12. adjust font-weights of edit form

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    968d06a View commit details
    Browse the repository at this point in the history

  13. create controller method to load correct picture path, add uploads to… 

    … assets path, move cancel button on edit view and fix view not loading when department name missing
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bee42d0 View commit details
    Browse the repository at this point in the history

  14. add default avatar to public directory

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    37ba30f View commit details
    Browse the repository at this point in the history

  15. make view display nil properties of person as -, create picture contr… 

    …oller and remove picture_path method from people_controller, use new picture controller to load pictures correctly in view
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d287a2c View commit details
    Browse the repository at this point in the history

  16. add picture to permitted attrs

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    15c315e View commit details
    Browse the repository at this point in the history

  17. add dummy role adding button in person edit view and make marital sta… 

    …tus dropdown have correct value selected on edit
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e958f7b View commit details
    Browse the repository at this point in the history

  18. start working on updating roles by renaming the params in the form an… 

    …d overriding the update method in the controller
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    789f0f9 View commit details
    Browse the repository at this point in the history

  19. rewrite profile to use fields_for instead of a normal for loop, for s… 

    …aving new roles
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8219d40 View commit details
    Browse the repository at this point in the history

  20. add person_roles_attributes to permitted attributes

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a3dfe6b View commit details
    Browse the repository at this point in the history

  21. make edit view conditionally display the second nationality dropdown … 

    …depending on checkbox state
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9daf507 View commit details
    Browse the repository at this point in the history

  22. make person overview and edit view responsive

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    118c9a0 View commit details
    Browse the repository at this point in the history

  23. remove overflow scroll from person overview and edit view

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    12ac44a View commit details
    Browse the repository at this point in the history

  24. move fields of role form to partial and start writing logic to create… 

    … new roles
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    10928cc View commit details
    Browse the repository at this point in the history

  25. add remove button to roles in edit view and fix rendering of form

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f202713 View commit details
    Browse the repository at this point in the history

  26. add missing class to person role fields partial, add js method to mak… 

    …e remove roles work and update eventlistener of add role to correctly fire and trigger
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8d9c5f8 View commit details
    Browse the repository at this point in the history

  27. refactor too long lines, add comments, move whole edit form to form p… 

    …artial and create a turbostream that is triggered when edit fails, refactor the has_nationality2 property in the edit view
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a26f027 View commit details
    Browse the repository at this point in the history

  28. fix name attribute of contries in form

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9e5677c View commit details
    Browse the repository at this point in the history

  29. replace pzsh container with div to prevent moving whole page to center

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    743f589 View commit details
    Browse the repository at this point in the history

  30. style the show view of the person

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d659580 View commit details
    Browse the repository at this point in the history

  31. fix styling of edit view

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ad9afaa View commit details
    Browse the repository at this point in the history

  32. change w-100 to mw-100 everywhere in edit view

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    df96049 View commit details
    Browse the repository at this point in the history

  33. make image instantly update on file upload by using a stimulus contro… 

    …ller
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0bd65fa View commit details
    Browse the repository at this point in the history

  34. fix nationality2 checkbox

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9e52451 View commit details
    Browse the repository at this point in the history

  35. add picture cache for profile picture, style picture upload button fi… 

    …x error in person edit turbostream
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6490198 View commit details
    Browse the repository at this point in the history

  36. adjust color of buttons in person edit view

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8b6fce7 View commit details
    Browse the repository at this point in the history

  37. fix loading of profile picture after saving and style profile picture… 

    … upload button
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0c6b0f4 View commit details
    Browse the repository at this point in the history

  38. fix template error in show view of person, when person role level or … 

    …percent are nil, add classes to person templates for testing purposes and write first test to test if person is editable
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5cb14ff View commit details
    Browse the repository at this point in the history

  39. fix rubocop offenses

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e1c5105 View commit details
    Browse the repository at this point in the history

  40. fix last rubocop offenses

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bc470f6 View commit details
    Browse the repository at this point in the history

  41. write test that tests if editing a person is possible, assign id to s… 

    …ave and edit buttons for testing, make editing shortname possible
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    38b38e0 View commit details
    Browse the repository at this point in the history

  42. remove unwanted header from person profile

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4b4e4cc View commit details
    Browse the repository at this point in the history

  43. change dateformat in equal check of feature spec to make test work ac… 

    …ross all systems
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2850196 View commit details
    Browse the repository at this point in the history

  44. change _ to - in ids of save cancel and edit buttons and write test t… 

    …hat tests if canceling really doesnt save the person
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    243278e View commit details
    Browse the repository at this point in the history

  45. revert formating of date in test

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d393baf View commit details
    Browse the repository at this point in the history

  46. bring back formatting of date in test

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ef03dfa View commit details
    Browse the repository at this point in the history

  47. Change filling of date input in test to default html

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bb68559 View commit details
    Browse the repository at this point in the history

  48. Fix date formating for filling form in test

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3af92e5 View commit details
    Browse the repository at this point in the history

  49. make test also upload new image and check if avatar upload field exists

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0fcc97f View commit details
    Browse the repository at this point in the history

  50. rename method of has_nationality2 checkbox to checked and start writi… 

    …ng people_controller spec
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    89cc571 View commit details
    Browse the repository at this point in the history

  51. Add param converter concerns to check if param is false, use new fals… 

    …e method to check if person has nationality2, write test to test if nationality2 is set according to checkbox
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0a724e7 View commit details
    Browse the repository at this point in the history

  52. Remove rubocop offense and check if nationality2 is not null initiall… 

    …y in person controller test
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dfca71b View commit details
    Browse the repository at this point in the history

  53. style person show view to wrap text and replace some unless statement… 

    …s with ternary operators
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c01f61a View commit details
    Browse the repository at this point in the history

  54. reimplement whole picture controller from api namespace, cleanup code

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6dfda1e View commit details
    Browse the repository at this point in the history

  55. move picture test from api namespace to people namespace and xdescrib… 

    …e old test
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    920eadd View commit details
    Browse the repository at this point in the history

  56. fix rubocop offense

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f2f07a1 View commit details
    Browse the repository at this point in the history

  57. Dont display role percentage if there is no role percentage in person… 

    … overview
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    03879f4 View commit details
    Browse the repository at this point in the history

  58. revert unnecessary file change

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fd9699a View commit details
    Browse the repository at this point in the history

  59. remove unneeded picture helpers and specs

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    10911d4 View commit details
    Browse the repository at this point in the history

  60. add translations for marital statuses

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bdcd91f View commit details
    Browse the repository at this point in the history

  61. fix loading of avatar because it vanished in specific cases

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7213b45 View commit details
    Browse the repository at this point in the history

  62. fix translation yml files and translate marital status and nationality

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f494fec View commit details
    Browse the repository at this point in the history

  63. fix tests after localization and test if avatar is saved in feature spec

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    287e1c9 View commit details
    Browse the repository at this point in the history

  64. replace alpha2 code with actual country name in people show view

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2ffd1ec View commit details
    Browse the repository at this point in the history

  65. make picture controller inherit from new crud controller instead of a… 

    …pi crud controller
    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    51df400 View commit details
    Browse the repository at this point in the history

  66. make people controller test also test if nationality is saved correctly

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a9cae8a View commit details
    Browse the repository at this point in the history

  67. fix specs after rebase

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    eef8242 View commit details
    Browse the repository at this point in the history

  68. move functions to add and remove roles to stimulus controller

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dc88a09 View commit details
    Browse the repository at this point in the history

  69. Fix picture controller spec and rename feature spec

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    42b8ec9 View commit details
    Browse the repository at this point in the history

  70. make show all link not display in edit view

    @RandomTannenbaum
    RandomTannenbaum committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    aebcbd3 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. resolve styling conversations

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a368060 View commit details
    Browse the repository at this point in the history

  2. Rename ms translations to marital_statuses and refactor all its usage… 

    …s, interpolate bobs id in picture controller test
    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    999499d View commit details
    Browse the repository at this point in the history

  3. Bring back api route to un-xdescribe api test

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    07f24f4 View commit details
    Browse the repository at this point in the history

  4. move some stuff from view to helper methods in new person_helper

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cdf6d6d View commit details
    Browse the repository at this point in the history

  5. make attribute headers in view look like in old skills

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1b2e35a View commit details
    Browse the repository at this point in the history

  6. fix loading of picture on form validation failure

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2f76704 View commit details
    Browse the repository at this point in the history

  7. Move code to check if picture is cached to helper method

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4986d9d View commit details
    Browse the repository at this point in the history

  8. rename method from avatar_cached to avatar_cached?

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1cbc937 View commit details
    Browse the repository at this point in the history

  9. add paddings to information of person for improved distinguishability

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    48c2893 View commit details
    Browse the repository at this point in the history

  10. fix deleting of roles when edit form fails

    @RandomTannenbaum
    RandomTannenbaum committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    efbd837 View commit details
    Browse the repository at this point in the history