Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back user profile #599

Merged
merged 80 commits into from
Mar 15, 2024
Merged

Bring back user profile #599

merged 80 commits into from
Mar 15, 2024

Conversation

RandomTannenbaum
Copy link
Collaborator

No description provided.

@RandomTannenbaum RandomTannenbaum force-pushed the feature/569-bring-back-user-profiles branch from 122c92c to 574917c Compare February 20, 2024 08:42
@ManuelMoeri ManuelMoeri linked an issue Feb 21, 2024 that may be closed by this pull request
New-Skills: Migrate user profile back to Rails #569
Closed
@RandomTannenbaum RandomTannenbaum force-pushed the feature/569-bring-back-user-profiles branch from 6c23415 to 98bcf28 Compare March 1, 2024 12:40
@RandomTannenbaum
Copy link
Collaborator Author

Todo:

  • Translation
  • Test for picture in save person test
  • Fix visual bug

@RandomTannenbaum
add first tables to display profile data
f8a73a1
@RandomTannenbaum
add language and profile pic to view and add a new section in the vie…
8da7aad 
…w respectively. make roles display correctly
@RandomTannenbaum
style headers of user profile data table and move edit link
0414a9a
@RandomTannenbaum
display languages in a very basic way
fd6458b
@RandomTannenbaum
make account overview display country name instead of alpha2 code and…
86d149c 
… implement most of the edit form to edit a user-profile
@RandomTannenbaum
fix displaying of values in dropdowns, to represent actual state of o…
bdd96ac 
…bject and add fields for percentage and level
@RandomTannenbaum
label role form fields and correctly display role in overview
5a90a03
@RandomTannenbaum
replace @entry with @person after rebase and remove nested_models and…
7d49266 
… permitted_relationships from people controller
@RandomTannenbaum
move edit form to edit route and add turbo frame that loads edit form…
6feae9f 
… in overview when edit is clicked and remove absolute width from account overview tables
@RandomTannenbaum
fix alignment of tables, set width of input fields to match table wid…
a2a154e 
…th, add save button and fix saving of form
@RandomTannenbaum
style edit form to use bootstrap form fields
46055cb
@RandomTannenbaum
adjust font-weights of edit form
968d06a
@RandomTannenbaum
create controller method to load correct picture path, add uploads to…
bee42d0 
… assets path, move cancel button on edit view and fix view not loading when department name missing
@RandomTannenbaum
add default avatar to public directory
37ba30f
@RandomTannenbaum
make view display nil properties of person as -, create picture contr…
d287a2c 
…oller and remove picture_path method from people_controller, use new picture controller to load pictures correctly in view
@RandomTannenbaum
add picture to permitted attrs
15c315e
@RandomTannenbaum
add dummy role adding button in person edit view and make marital sta…
e958f7b 
…tus dropdown have correct value selected on edit
@RandomTannenbaum
start working on updating roles by renaming the params in the form an…
789f0f9 
…d overriding the update method in the controller
@RandomTannenbaum
rewrite profile to use fields_for instead of a normal for loop, for s…
8219d40 
…aving new roles
@RandomTannenbaum
add person_roles_attributes to permitted attributes
a3dfe6b
@RandomTannenbaum
make edit view conditionally display the second nationality dropdown …
9daf507 
…depending on checkbox state
@RandomTannenbaum
make person overview and edit view responsive
118c9a0
@RandomTannenbaum
remove overflow scroll from person overview and edit view
12ac44a
@RandomTannenbaum
move fields of role form to partial and start writing logic to create…
10928cc 
… new roles
@RandomTannenbaum
add remove button to roles in edit view and fix rendering of form
f202713
@RandomTannenbaum
add missing class to person role fields partial, add js method to mak…
8d9c5f8 
…e remove roles work and update eventlistener of add role to correctly fire and trigger
@RandomTannenbaum RandomTannenbaum force-pushed the feature/569-bring-back-user-profiles branch from 5c7a8a0 to a9cae8a Compare March 12, 2024 11:39
@RandomTannenbaum RandomTannenbaum marked this pull request as ready for review March 12, 2024 16:00
@RandomTannenbaum RandomTannenbaum marked this pull request as draft March 12, 2024 16:06
@RandomTannenbaum
Copy link
Collaborator Author

Ready for review, but one bug to be solved

Robin481
Robin481 requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, have some small inputs here and there.

And one more thing:
Visually what is missing is a clear distinction between the Title and the field values.
Make the titles such as Abschluss more visually distinct from what the user has entered.

app/assets/stylesheets/styles.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/styles.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/styles.scss Show resolved Hide resolved
app/assets/stylesheets/styles.scss Show resolved Hide resolved
app/assets/stylesheets/styles.scss Outdated Show resolved Hide resolved
app/views/people/show.html.haml Outdated Show resolved Hide resolved
app/views/people/show.html.haml Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
spec/controllers/api/people/picture_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/people/picture_controller_spec.rb Outdated Show resolved Hide resolved
@RandomTannenbaum RandomTannenbaum marked this pull request as ready for review March 15, 2024 07:37
@RandomTannenbaum
Copy link
Collaborator Author

It seems like I found a fix for the problem with the person roles 🥳

@Robin481 Robin481 merged commit 69f4f08 into master Mar 15, 2024
2 checks passed
@Robin481 Robin481 deleted the feature/569-bring-back-user-profiles branch March 15, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin481 Robin481 Robin481 approved these changes

Assignees

@Robin481 Robin481

@RandomTannenbaum RandomTannenbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New-Skills: Migrate user profile back to Rails
2 participants
@RandomTannenbaum @Robin481