Add email validation in person new and edit #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkleisa
changed the title
lkleisa
force-pushed
the
feature/497-email-regex
branch
4 times, most recently
from
f8ce8f0
to
7c9ca18
Compare
Robin481
requested changes
Mar 3, 2023
|
Looking good 🥳 implement small feedback and we should be good |
lkleisa
force-pushed
the
feature/497-email-regex
branch
from
7c9ca18
to
e3262ce
Compare
|
Follow up issue: #512 |
lkleisa
force-pushed
the
feature/497-email-regex
branch
from
97c11d6
to
aca253c
Compare
Robin481
approved these changes
Mar 7, 2023
kcinay055679
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Add new email regex for person edit and rename file person edit to person form * Add email validation for create new person in backend * Add german validation message and rename person form to person edit * Make rubocop happy * Write backend test for email validation * Write frontend test for email validation * Write Acceptance test for invalid email in person new * Use other click method to call submit button * Remove unused code in people-new.js * Fix frontend test for email validation on create person * Fix type fault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state is described here: #497