-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add email validation in person new and edit (#501)
* Add new email regex for person edit and rename file person edit to person form * Add email validation for create new person in backend * Add german validation message and rename person form to person edit * Make rubocop happy * Write backend test for email validation * Write frontend test for email validation * Write Acceptance test for invalid email in person new * Use other click method to call submit button * Remove unused code in people-new.js * Fix frontend test for email validation on create person * Fix type fault
- Loading branch information
Showing
9 changed files
with
180 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,6 +73,30 @@ | |
end | ||
end | ||
|
||
context 'email' do | ||
|
||
it 'should be invalid when email is nil' do | ||
person = people(:bob) | ||
person.email = nil | ||
expect(person).not_to be_valid | ||
expect(person.errors.messages[:email].first).to eq('muss ausgefüllt werden') | ||
end | ||
|
||
it 'should be invalid when email format is invalid' do | ||
person = people(:bob) | ||
person.email = "email" | ||
expect(person).not_to be_valid | ||
expect(person.errors.messages[:email].first).to eq('Format nicht gültig') | ||
end | ||
|
||
it 'should be valid when email format is correct' do | ||
person = people(:bob) | ||
person.email = "[email protected]" | ||
expect(person).to be_valid | ||
end | ||
|
||
end | ||
|
||
it 'should not be more than 100 characters' do | ||
person = people(:bob) | ||
person.location = SecureRandom.hex(100) | ||
|