Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ubuntu 16.04 (EOL) #374

Closed
wants to merge 23 commits into from
Closed

Drop Ubuntu 16.04 (EOL) #374

wants to merge 23 commits into from

Commits on Oct 8, 2023

  1. Prepare for PDK update

    Sync from the puppetlabs-apt module for settings related to GitHub
    actions support and other CI "deprecation".
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    6168886 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1791e09 View commit details
    Browse the repository at this point in the history
  3. Pet rubocop

    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    f72d3d1 View commit details
    Browse the repository at this point in the history
  4. Modernize/Fix CI

    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    3e25635 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cd74f49 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8eabccc View commit details
    Browse the repository at this point in the history
  7. Ignore messages from ls(1) on stderr

    We are interested in the list of all installed modules, we do not care
    about messages on stderr like:
    ```
    bash: warning: setlocale: LC_ALL: cannot change locale (fr_FR.UTF-8)
    ```
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    aeecff2 View commit details
    Browse the repository at this point in the history
  8. Conditionaly include postgresql::server::contrib

    We need the contrib packages only with older versions of PostgreSQL.
    While here include this class when it is needed instead of using
    a resource to avoid conflicts when another module wants to do this.
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    ae31048 View commit details
    Browse the repository at this point in the history
  9. Mark broken tests as pending

    PostgreSQL is configured to use snakeoil certificates, but PuppetDB
    expect to use the Puppet certificates to authenticate with needs more
    code that we currently have in the tests.
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    00c4580 View commit details
    Browse the repository at this point in the history
  10. Add missing dependency

    the provision module was not found in /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/spec/fixtures/modules, please amend the .fixtures.yml file
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_helper.rb:121:in `provision'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_tasks.rb:81:in `block (2 levels) in <top (required)>'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:21:in `block in execute'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/client.rb:65:in `start_span'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:16:in `execute'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
    /opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `load'
    /opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `<main>'
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    c658702 View commit details
    Browse the repository at this point in the history
  11. Add missing dependency

    puppet_agent was not found in /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/spec/fixtures/modules, please amend the .fixtures.yml file
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_helper.rb:221:in `block in install_agent'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/client.rb:65:in `start_span'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/forwardable-1.3.2/lib/forwardable.rb:238:in `start_span'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_helper.rb:210:in `install_agent'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_tasks.rb:126:in `block (2 levels) in <top (required)>'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:21:in `block in execute'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/client.rb:65:in `start_span'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:16:in `execute'
    /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
    /opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `load'
    /opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `<main>'
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    8a09ec3 View commit details
    Browse the repository at this point in the history
  12. Add missing dependency

    Bolt::PAL::PALError: Could not find module facts containing task file bash.sh
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    2eabf41 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ab1ebc6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0f9ab7e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    adfe470 View commit details
    Browse the repository at this point in the history
  16. pdk update --template-ref 3.0.0

    Needed some minor adjustment to `.sync.yml`.
    smortex committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    0b8973b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    68d8c64 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Disable out-of-scope puppet-lint checks

    For now we want to have running CI.  We do not care about the module
    being fully documented.
    smortex committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0af3a80 View commit details
    Browse the repository at this point in the history
  2. Remove local facts overrides

    They break adding facts from a context.
    smortex committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b8a52bc View commit details
    Browse the repository at this point in the history
  3. Match the ensure value of the manifest

    This was changed in 68d8c64 to fix
    puppet lint issues, but as the test suite was not run it passed through.
    smortex committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    cb14e5d View commit details
    Browse the repository at this point in the history
  4. Match owner / mode of the manifest

    This was changed in 010bf13 to match
    best practice, but as the test suite was not run it passed through.
    smortex committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    62550d8 View commit details
    Browse the repository at this point in the history
  5. Add path to the custom facts

    The systemd module use this to run `systemctl daemon-reload`.  Set an
    arbitrary value to avoid:
    
    > Validation of Exec[systemd-postgresql.service-systemctl-daemon-reload] failed: 'systemctl' is not qualified and no path was specified. Please qualify the command or specify a path.
    smortex committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e62e37d View commit details
    Browse the repository at this point in the history
  6. Drop Ubuntu 16.04 (EOL)

    Ubuntu reached EOL a few years ago.  The module rely on modules that
    drop support for this legacy version of Ubuntu e.g. the
    puppetlabs-postgresql module removed support 6+ months ago.
    
    Drop support for Ubuntu.
    smortex committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2b1feae View commit details
    Browse the repository at this point in the history