Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ubuntu 16.04 (EOL) #374

Closed
wants to merge 23 commits into from
Closed

Drop Ubuntu 16.04 (EOL) #374

wants to merge 23 commits into from

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Oct 9, 2023 •
edited
Loading

This PR include #344

@smortex
Prepare for PDK update
6168886 
Sync from the puppetlabs-apt module for settings related to GitHub
actions support and other CI "deprecation".
@smortex
pdk update --template-ref 2.4.0
1791e09
@smortex
Pet rubocop
f72d3d1
@smortex
Modernize/Fix CI
3e25635
@smortex
Fix acceptance tests to work with Litmus
cd74f49
@smortex
Fix installation path of puppet modules
8eabccc
@smortex
Ignore messages from ls(1) on stderr
aeecff2 
We are interested in the list of all installed modules, we do not care
about messages on stderr like:
```
bash: warning: setlocale: LC_ALL: cannot change locale (fr_FR.UTF-8)
```
@smortex
Conditionaly include postgresql::server::contrib
ae31048 
We need the contrib packages only with older versions of PostgreSQL.
While here include this class when it is needed instead of using
a resource to avoid conflicts when another module wants to do this.
@smortex
Mark broken tests as pending
00c4580 
PostgreSQL is configured to use snakeoil certificates, but PuppetDB
expect to use the Puppet certificates to authenticate with needs more
code that we currently have in the tests.
@smortex
Add missing dependency
c658702 
the provision module was not found in /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/spec/fixtures/modules, please amend the .fixtures.yml file
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_helper.rb:121:in `provision'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_tasks.rb:81:in `block (2 levels) in <top (required)>'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:21:in `block in execute'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/client.rb:65:in `start_span'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:16:in `execute'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `load'
/opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `<main>'
@smortex
Add missing dependency
8a09ec3 
puppet_agent was not found in /home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/spec/fixtures/modules, please amend the .fixtures.yml file
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_helper.rb:221:in `block in install_agent'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/client.rb:65:in `start_span'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/forwardable-1.3.2/lib/forwardable.rb:238:in `start_span'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_helper.rb:210:in `install_agent'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-0.34.3/lib/puppet_litmus/rake_tasks.rb:126:in `block (2 levels) in <top (required)>'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:21:in `block in execute'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/client.rb:65:in `start_span'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/honeycomb-beeline-2.11.0/lib/honeycomb/integrations/rake.rb:16:in `execute'
/home/runner/work/puppetlabs-puppetdb/puppetlabs-puppetdb/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `load'
/opt/hostedtoolcache/Ruby/2.7.6/x64/bin/bundle:23:in `<main>'
@smortex
Add missing dependency
2eabf41 
Bolt::PAL::PALError: Could not find module facts containing task file bash.sh
@smortex
Auto-select the default PostgreSQL version
ab1ebc6
@smortex
Fix CI failures related to legacy facts
0f9ab7e
@smortex
More CI fixes with latest posgresql module
adfe470
@smortex
pdk update --template-ref 3.0.0
0b8973b 
Needed some minor adjustment to `.sync.yml`.
@smortex
bundle exec puppet-lint manifests --fix
68d8c64
@smortex
Disable out-of-scope puppet-lint checks
0af3a80 
For now we want to have running CI.  We do not care about the module
being fully documented.
@smortex
Remove local facts overrides
b8a52bc 
They break adding facts from a context.
@smortex
Match the ensure value of the manifest
cb14e5d 
This was changed in 68d8c64 to fix
puppet lint issues, but as the test suite was not run it passed through.
@smortex
Match owner / mode of the manifest
62550d8 
This was changed in 010bf13 to match
best practice, but as the test suite was not run it passed through.
@smortex
Add path to the custom facts
e62e37d 
The systemd module use this to run `systemctl daemon-reload`.  Set an
arbitrary value to avoid:

> Validation of Exec[systemd-postgresql.service-systemctl-daemon-reload] failed: 'systemctl' is not qualified and no path was specified. Please qualify the command or specify a path.
@smortex
Drop Ubuntu 16.04 (EOL)
2b1feae 
Ubuntu reached EOL a few years ago.  The module rely on modules that
drop support for this legacy version of Ubuntu e.g. the
puppetlabs-postgresql module removed support 6+ months ago.

Drop support for Ubuntu.
@smortex smortex requested review from bastelfreak and a team as code owners October 9, 2023 18:49
@smortex
Copy link
Collaborator Author

smortex commented Oct 9, 2023

All unit tests pass \o/

Cc @austb

As stated in #344 (comment) I will be happy to help fixing acceptance tests if I know we are going somewhere (well, I will go on vacation first because it is a sensitive thing to do when working on this module, but I will be back in a few weeks). Thanks!

@h0tw1r3 h0tw1r3 mentioned this pull request Dec 19, 2023
Closed
h0tw1r3 added a commit to h0tw1r3/puppetlabs-puppetdb that referenced this pull request Jan 25, 2024
@h0tw1r3
mark test pending platform support removal
427e6a2 
puppetlabs#374
h0tw1r3 added a commit to h0tw1r3/puppetlabs-puppetdb that referenced this pull request Jan 27, 2024
@h0tw1r3
mark test pending platform support removal
f20697f 
puppetlabs#374
@h0tw1r3
Copy link
Contributor

h0tw1r3 commented Jan 29, 2024

closed by #384

@h0tw1r3 h0tw1r3 closed this Jan 29, 2024
@h0tw1r3 h0tw1r3 deleted the drop-ubuntu16 branch May 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smortex @h0tw1r3 @bastelfreak