Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add documentation on useAzureMonitorSdk feature flag #62

Merged
merged 5 commits into from
Jun 7, 2024
Merged

feat: add documentation on useAzureMonitorSdk feature flag #62

merged 5 commits into from
Jun 7, 2024

Conversation

hkfgo
Copy link
Contributor

@hkfgo hkfgo commented May 25, 2024 •
edited by tomkerkhove
Loading

Documentation on Azure Monitor SDK migration

Relates to tomkerkhove/promitor#2209

@hkfgo hkfgo requested a review from tomkerkhove as a code owner May 25, 2024 01:09
@CLAassistant
Copy link

CLAassistant commented May 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hkfgo hkfgo changed the title add documentation on useAzureMonitorSdk feature falg feat: add documentation on useAzureMonitorSdk feature falg May 25, 2024
@netlify Netlify
Copy link

netlify bot commented May 25, 2024 •
edited
Loading

✅ Deploy Preview for promitor-docs ready!

Name Link
🔨 Latest commit 72cd814
🔍 Latest deploy log https://app.netlify.com/sites/promitor-docs/deploys/6660d2bf8337bf000891909b
😎 Deploy Preview https://deploy-preview-62--promitor-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 25, 2024
@hkfgo hkfgo changed the title feat: add documentation on useAzureMonitorSdk feature falg feat: add documentation on useAzureMonitorSdk feature flag May 25, 2024
@hkfgo hkfgo mentioned this pull request May 25, 2024
Merged
@hkfgo hkfgo mentioned this pull request Jun 3, 2024
Merged
@hkfgo
Copy link
Contributor Author

hkfgo commented Jun 3, 2024

I'm seeing this failure:

invalid url - /configuration/v2.x/runtime/scraper/#what-happens-when-metrics-are-unavailable-for-multi-dimensional-metrics [404] [faq.md]

Seems unrelated to my change? Let me see if I can fix it..

tomkerkhove
tomkerkhove approved these changes Jun 3, 2024
View reviewed changes
docs/scraping/runtime-configuration.md Outdated Show resolved Hide resolved
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 3, 2024
@hkfgo @tomkerkhove
Update docs/scraping/runtime-configuration.md
d46dff4 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Stephen Chen <[email protected]>
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ✅ Approved Pull Request has been approved and can be merged labels Jun 3, 2024
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 5, 2024
@tomkerkhove
Copy link
Member

@hkfgo Can you sign the CLA please?

@hkfgo
Copy link
Contributor Author

hkfgo commented Jun 7, 2024

Signed!

@tomkerkhove tomkerkhove merged commit 0b47e91 into promitor:main Jun 7, 2024
10 checks passed
@tomkerkhove
Copy link
Member

Thanks!

@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkfgo @CLAassistant @tomkerkhove