Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Azure Monitor SDK Feature Flag to Runtime Configuration #2507

Conversation

hkfgo
Copy link
Contributor

@hkfgo hkfgo commented Jun 3, 2024

Per our discussion here: promitor/docs#62 (comment)

@hkfgo hkfgo requested a review from tomkerkhove as a code owner June 3, 2024 01:55
Copy link

github-actions bot commented Jun 3, 2024

Thank you for your contribution! 🙏 We will review it as soon as possible.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jun 3, 2024
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had missed this in initial PR

.github/workflows/templates-build-push-image.yml Outdated Show resolved Hide resolved
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 3, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ✅ Approved Pull Request has been approved and can be merged labels Jun 3, 2024
@tomkerkhove tomkerkhove merged commit 2c1ac6b into tomkerkhove:master Jun 4, 2024
26 of 27 checks passed
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants