Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow configuration of simulator sdk version when running spm tests #852

Merged
merged 6 commits into from
Apr 30, 2024
Merged

chore: allow configuration of simulator sdk version when running spm tests #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4afe76b
fix xcode version SPM workflow
jnewc Apr 29, 2024
3d26fbd
allow passing of sim version to spm test lane
jnewc Apr 29, 2024
1524a93
Merge branch 'master' into jn/fix-xcode-version-workflow
jnewc Apr 29, 2024
fc82057
Merge branch 'master' into jn/fix-xcode-version-workflow
jnewc Apr 29, 2024
ff2635a
Simulator iPhone version 15 -> 14
jnewc Apr 29, 2024
b790684
Merge branch 'master' into jn/fix-xcode-version-workflow
jnewc Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-test-upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
MATCH_KEYCHAIN_NAME: ${{ secrets.MATCH_KEYCHAIN_NAME }}
MATCH_KEYCHAIN_PASSWORD: ${{ secrets.MATCH_KEYCHAIN_PASSWORD }}
SOURCE_BRANCH: ${{ github.head_ref }}

sdk-unit-tests:
runs-on: macos-13-large
timeout-minutes: 20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/xcode-versions-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Build and archive app via SPM
if: ${{ matrix.variant == 'spm' }}
run: |
bundle exec fastlane test_spm
bundle exec fastlane test_spm sim_version:16.4
env:
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
MATCH_GIT_PRIVATE_KEY: ${{ secrets.SSH_KEY }}
Expand Down
25 changes: 0 additions & 25 deletions Debug App/Primer.io Debug App.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

This file was deleted.

11 changes: 7 additions & 4 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,19 +112,22 @@ platform :ios do
end

desc 'This action builds the app using the SPM integration'
lane :test_spm do
lane :test_spm do |options|
common_pre_build_action

sim_version = options[:sim_version] || "17.2"

run_tests(
package_path: ".",
scheme: "PrimerSDKTests",
sdk: "iphonesimulator17.2",
destination: "OS=17.2,name=iPhone 15 Pro",
sdk: "iphonesimulator#{sim_version}",
destination: "OS=#{sim_version},name=iPhone 14 Pro",
result_bundle: true,
code_coverage: true,
output_directory: Dir.pwd + "/test_output"
)
end

lane :build_cocoapods do |options|
common_pre_build_action

Expand Down