Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow configuration of simulator sdk version when running spm tests #852

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Apr 29, 2024

Description

The simulator sdk version must be specified when running SPM tests, so the xcode version matrix workflow needs it to be configurable.

The version compatibility table for macOS/Xcode/Simulator is here.

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@jnewc jnewc requested a review from NQuinn27 April 29, 2024 10:01
@jnewc jnewc requested a review from a team as a code owner April 29, 2024 10:01
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against b790684

Copy link
Contributor

@jnewc jnewc merged commit 0fe95e1 into master Apr 30, 2024
7 checks passed
@jnewc jnewc deleted the jn/fix-xcode-version-workflow branch April 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants