Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

130-0feature/PaginationButton 컴포넌트 구현 #134

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

130-0feature/PaginationButton 컴포넌트 구현 #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc6d196
Fix: 리스트를 렌더링할 때 각 항목에 고유한 key prop을 제공하도록 변경
bluedog129 Oct 2, 2024
7c7b288
Feat: PaginationButton 구현
bluedog129 Oct 2, 2024
7aaa91c
Refactor: 불필요한 주석, import 제거
bluedog129 Oct 2, 2024
0c8eeb6
Fix: isActive를 부모로 부터 받아오는 로직이 불필요하다 생각해서 현재 페이지 받아오는걸로 변경
bluedog129 Oct 2, 2024
8348b5c
Fix: 'onClick' prop을 'onClickPaginationButton'로 변경하여 의미 명확화
bluedog129 Oct 2, 2024
04f47bb
Refactor: 변수 및 함수 코드 적절하게 정리
bluedog129 Oct 2, 2024
67db642
Refactor: onClick함수 관련 최적화
bluedog129 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/Footer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,26 @@
import React from 'react';
import * as S from './styles';
import interparkLogo from '@/assets/imgs/interpark-logo.png';
import kopisLogo from '@/assets/imgs/kopis-logo.png';
import yes24Logo from '@/assets/imgs/yes24-logo.png';

const logoList = [
{ href: 'https://www.interpark.com', alt: 'interpark', src: interparkLogo },
{ href: 'https://www.kopis.or.kr', alt: 'KOPIS', src: kopisLogo },
{ href: 'https://www.yes24.com', alt: 'YES24', src: yes24Logo },
];

export const Footer = () => {
return (
<S.FooterContainer>
<S.StyledFooter>
{logoList.map((logo, index) => (
<>
<React.Fragment key={logo.alt}>
<a href={logo.href} target="_blank" rel="noopener noreferrer">
<S.Logo src={logo.src} alt={logo.alt} />
</a>
{index < logoList.length - 1 && <S.StyledSeperator />}
</>
</React.Fragment>
))}
</S.StyledFooter>
</S.FooterContainer>
Expand Down
20 changes: 20 additions & 0 deletions src/components/PaginationButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import * as S from './styles';

interface PaginationButtonProps {
pageNumber: number;
currentPage: number;
onClickPaginationButton: (page: number) => void;
}

export const PaginationButton = ({ pageNumber, currentPage, onClickPaginationButton }: PaginationButtonProps) => {
const isActive = pageNumber === currentPage;
const onClick = (pageNumber: number) => () => onClickPaginationButton(pageNumber);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래 함수 추가하시고, onClick 이벤트에 onClick={onClick(page)} 로 넣어주시면 될 거에요!

onClick = (page:number)=> () =>onClickPaginationButton(page)

return (
<S.PaginationButton $isActive={isActive} onClick={onClick(pageNumber)}>
{pageNumber}
</S.PaginationButton>
);
};

export default PaginationButton;
16 changes: 16 additions & 0 deletions src/components/PaginationButton/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import styled from 'styled-components';

interface StyledPaginationButtonProps {
$isActive: boolean;
}

export const PaginationButton = styled.button<StyledPaginationButtonProps>`
padding: 5px 8px;
margin: 0 4px;
border: none;
border-radius: 4px;
background-color: ${({ $isActive, theme }) => ($isActive ? theme.colors.primary : theme.colors.white)};
color: ${({ $isActive, theme }) => ($isActive ? theme.colors.white : theme.colors.black)};
cursor: pointer;
`;