130-0feature/PaginationButton 컴포넌트 구현 #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlee9999
requested changes
Oct 2, 2024
| interface PaginationButtonProps { | ||
| number: number; | ||
| currentPage: number; | ||
| onClick: (number: number) => void; |
There was a problem hiding this comment.
onClickPaginationButton 으로 바꾸어 주세요!
그리고 매개변수 네이밍이 number보단 page가 좋을 것 같습니다
|
|
||
| export const PaginationButton = ({ number, currentPage, onClick }: PaginationButtonProps) => { | ||
| const isActive = number === currentPage; | ||
|
|
There was a problem hiding this comment.
아래 함수 추가하시고, onClick 이벤트에 onClick={onClick(page)} 로 넣어주시면 될 거에요!
onClick = (page:number)=> () =>onClickPaginationButton(page)
shlee9999
requested changes
Oct 2, 2024
| const isActive = number === currentPage; | ||
|
|
||
| const onClick = (page: number) => () => onClickPaginationButton(page); | ||
|
|
||
| return ( | ||
| <S.PaginationButton $isActive={isActive} onClick={() => onClick(number)}> |
There was a problem hiding this comment.
여기 onClick에 () => onClick(number) 대신 onClickPaginationButton(page) 넣어주시면 댑니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
페이지네이션 버튼 컴포넌트를 구현했습니다.
🖼️ Screenshots
✅ PR Checklist
🔗 References
💬 Comments