feat: complexity checker plugin #169
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 75.35% 75.00% -0.35%
==========================================
Files 87 85 -2
Lines 13033 12860 -173
Branches 1225 1199 -26
==========================================
- Hits 9821 9646 -175
- Misses 3212 3214 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| */ | ||
| maxWarningLevel?: number; | ||
| /** If set, maps complexity based on asset or view type */ | ||
| assetComplexity?: Record<string, number>; |
There was a problem hiding this comment.
We might want to consider accepting any as a key so we can assign weights for assets that are registered with more than just a type, as those might have more complexity than the base asset is, i.e. if { type: 'asset', role: 'enhanced' } accepts another asset slot than just { type: 'asset' }
There was a problem hiding this comment.
Thanks for this callout - agreed that including other slots than just type to measure asset complexity would provide additional data points, but at this time we're going to keep it simple just to get this out. I've added in TODO comments so that we don't forget about this.
|
/canary |
1 similar comment
|
/canary |
Addresses #162.
Covers the following scenarios:
Change Type (required)
Indicate the type of change your pull request is:
patchminormajor📦 Published PR as canary version:
0.8.1--canary.169.3682Try this version out locally by upgrading relevant packages to 0.8.1--canary.169.3682