Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Out Code Complexity Metrics #162

Open
4 tasks
KetanReddy opened this issue Aug 27, 2024 · 0 comments · May be fixed by #169
Open
4 tasks

Build Out Code Complexity Metrics #162

KetanReddy opened this issue Aug 27, 2024 · 0 comments · May be fixed by #169
Labels
minor Increment the minor version when merged

Comments

@KetanReddy
Copy link
Member

KetanReddy commented Aug 27, 2024

Basic example started in this branch with a couple to-dos:

  • Get nested bindings/expressions working. Right now since we stop processing them after they are first detected they never fall through to finish the rest of the processing. I mocked out the basic interface for the model/expression evaluator so that might need to get fleshed out a bit more to do more parsing without having to do processing.
  • Identify and weight nodes with Template functionality. Templates are a runtime hit for Player to expand the template so we should increase the weight of any nodes within a template (and increase that weight for compound templates) but for that we'll need to be able to determine if any node is the child of a template node which is something we currently can't do as part of the LSP. This is something we'll need to do though in general as we expand validation functionality (related [@player-tools/json-language-service] DuplicateIdPlugin: Template Support #91 )
  • Determine more accurate weighting of node types
  • Support config for weighting different Assets. Different integrations should be able to specify a weight that each asset/view has on the render and have that be reflected in the complexity score

Outcome

Finished Plugin with previously mentioned tasks closed

@KetanReddy KetanReddy added the minor Increment the minor version when merged label Aug 27, 2024
@kharrop kharrop linked a pull request Sep 24, 2024 that will close this issue
3 tasks
@kharrop kharrop linked a pull request Sep 24, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant