Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight current player instance #160

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

cehan-Chloe
Copy link
Contributor

@cehan-Chloe cehan-Chloe commented Aug 20, 2024

Add highlight for current instance

Screen.Recording.2024-09-05.at.2.30.15.PM.mov

Note:

  1. add id (playid) as optional param for each player instance. As devtools-basic-web-plugin was used in tto-webplayer, use default-id when no id passed in

  2. revert commit for updating pnpm as it breaks the devtool with error TypeError: Cannot read properties of null (reading 'useReducer')

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

When we have multiple Player instances on the same page, highlight current selected player instance

Version

Published prerelease version: 0.8.0-next.1

Changelog

Release Notes

Update Rules Versions (#163)

Update JS Rules to latest Aspect major

  • patch
  • minor
  • major

Fix Source Maps not Being Generated for DSL Content (#155)

Fix source maps not being generated for DSL content when compiled by the cli

Update Dependencies (#151)

  • Use Node 20
  • Use TypeScript 5.5

🚀 Enhancement

  • feat: doesn't exit with error if warn-only on dsl validation #159 (@rafbcampos)

🐛 Bug Fix

Authors: 5

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 120 lines in your changes missing coverage. Please review.

Project coverage is 72.77%. Comparing base (b45f3ae) to head (a8dd8bf).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ols/plugins/desktop/basic/src/WrapperComponent.tsx 0.00% 54 Missing ⚠️
devtools/messenger/src/index.ts 70.89% 38 Missing and 1 partial ⚠️
devtools/client/src/state/index.ts 0.00% 9 Missing ⚠️
devtools/plugins/desktop/basic/src/index.tsx 0.00% 7 Missing ⚠️
...plugins/desktop/common/src/state/usePluginState.ts 0.00% 7 Missing ⚠️
.../plugins/desktop/profiler/src/WrapperComponent.tsx 0.00% 2 Missing ⚠️
...tools/plugins/desktop/basic/src/constants/index.ts 0.00% 1 Missing ⚠️
...vtools/plugins/desktop/common/src/state/reducer.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   73.06%   72.77%   -0.29%     
==========================================
  Files          87       87              
  Lines       12945    13033      +88     
  Branches     1216     1225       +9     
==========================================
+ Hits         9458     9485      +27     
- Misses       3468     3528      +60     
- Partials       19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cehan-Chloe cehan-Chloe marked this pull request as ready for review September 5, 2024 18:40
@hborawski
Copy link
Contributor

the Player menu in the video seems to flicker between options before settling after selecting a Player instance, do we need to debounce the update there?

@cehan-Chloe
Copy link
Contributor Author

the Player menu in the video seems to flicker between options before settling after selecting a Player instance, do we need to debounce the update there?

sorry this is not the up-to-date recording. updated

@cehan-Chloe cehan-Chloe requested review from KetanReddy and removed request for adierkens September 6, 2024 19:53
@cehan-Chloe cehan-Chloe linked an issue Sep 9, 2024 that may be closed by this pull request
@cehan-Chloe cehan-Chloe merged commit f729239 into main Sep 9, 2024
6 of 8 checks passed
@cehan-Chloe cehan-Chloe deleted the devtool-highlight-instance branch September 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[devtools] Add Player instance highlight
4 participants