-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: highlight current player instance #160
Conversation
75ad498
to
c9790c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 73.06% 72.77% -0.29%
==========================================
Files 87 87
Lines 12945 13033 +88
Branches 1216 1225 +9
==========================================
+ Hits 9458 9485 +27
- Misses 3468 3528 +60
- Partials 19 20 +1 ☔ View full report in Codecov by Sentry. |
ef61c2e
to
6b2b8e7
Compare
the |
sorry this is not the up-to-date recording. updated |
Add highlight for current instance
Screen.Recording.2024-09-05.at.2.30.15.PM.mov
Note:
add id (playid) as optional param for each player instance. As
devtools-basic-web-plugin
was used in tto-webplayer, usedefault-id
when no id passed inrevert commit for updating pnpm as it breaks the devtool with error
TypeError: Cannot read properties of null (reading 'useReducer')
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Release Notes
When we have multiple Player instances on the same page, highlight current selected player instance
Version
Published prerelease version:
0.8.0-next.1
Changelog
Release Notes
Update Rules Versions (#163)
Update JS Rules to latest Aspect major
patch
minor
major
Fix Source Maps not Being Generated for DSL Content (#155)
Fix source maps not being generated for DSL content when compiled by the cli
Update Dependencies (#151)
🚀 Enhancement
🐛 Bug Fix
Authors: 5