Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] Add Player instance highlight #128

Closed
rafbcampos opened this issue Jun 10, 2024 · 0 comments · Fixed by #160
Closed

[devtools] Add Player instance highlight #128

rafbcampos opened this issue Jun 10, 2024 · 0 comments · Fixed by #160
Labels
enhancement New feature or request

Comments

@rafbcampos
Copy link
Contributor

We can have multiple Player instances on the same page. Although the basic dev tools plugin has a dropdown to select different Player instances, they are shown as IDs.

So this is an issue for adding support to highlight the currently inspected Player when we select the instance in the dropdown and add an icon button to highlight the Player instance being inspected when the user clicks on it.

Possible solutions on how to highlight the Player instance:

  • Add an ID to the WrapperComponent and add a script into the extension to add a border to an element for a given ID; or
  • Use a ContentScript to wrap the component based on an ID; or
  • Add an Event to highlight based on the Player ID, and hook that into the WrappedComponent, so we add/remove a class to add a border.
@rafbcampos rafbcampos added the enhancement New feature or request label Jun 10, 2024
@cehan-Chloe cehan-Chloe linked a pull request Sep 9, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant