Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Callback ordering for ConnectionState #702

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix Callback ordering for ConnectionState #702

merged 2 commits into from
Jun 11, 2024

Commits on Jun 9, 2024

  1. Fix ConnectionState being reported out of order 

    Before we launched a goroutine to announce every ConnectionState change
to users. These could then be sent to the user out of order.

This commit adds a connectionStateNotifier. The connectionStateNotifier
delivers them sequentially to the user.

Resolves #624
    @sukunrt
    sukunrt committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6078335 View commit details
    Browse the repository at this point in the history

  2. Use Notification Queue from 67cc918 more 

    Deliver Candidates and Selected CandidatePairs using the same queue.
This means that things are delivered in order and we don't have to worry
about blocking
    @Sean-Der @sukunrt
    Sean-Der authored and sukunrt committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    45043bd View commit details
    Browse the repository at this point in the history