Fix Callback ordering for ConnectionState #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we launched a goroutine to announce every ConnectionState change to users. These could then be sent to the user out of order. This commit adds a connectionStateNotifier. The connectionStateNotifier delivers them sequentially to the user. Resolves #624
Deliver Candidates and Selected CandidatePairs using the same queue. This means that things are delivered in order and we don't have to worry about blocking
sukunrt
force-pushed
the
v2-candidate-order
branch
from
c615206
to
45043bd
Compare
Sean-Der
approved these changes
Jun 9, 2024
|
LGTM! I’m a week out from new version of DTLS. New major version of WebRTC is next. excited to get off old versions |
|
Thanks @Sean-Der. Looking forward to webrtc v4. 🎉 |
|
@Sean-Der Can I merge this and cut a new release? |
|
Go for it @sukunrt ! Thanks for doing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already fixed on master. I've cherry picked 2 commits: d17be4d & 67cc918
Since
pion/webrtc/v3depends onpion/ice/v2it'd be nice if we can have av2release with these two commits.