-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Undo/Redo system #1817
Merged
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
d291117
Implement ability to switch between old and new backup system
MrStevns e755311
Remove anything but the most essential logic
MrStevns 0bc7331
Make it more obvious that we're calling the legacy system
MrStevns e9ef704
Make sure we always update the save counter
MrStevns c685bc7
Change feature dialog text
MrStevns d381cdf
Add another dialog when re-enabling the old system
MrStevns 849e4a1
Apply more cleanup before restructuring
MrStevns c41802a
Refactor backupManager
MrStevns aa12b52
Introduce the new backup system to stroke tools and polyline.
MrStevns f9c93a2
Add backup for smudge tool
MrStevns 28df936
Remove commented code
MrStevns cb30ce6
Update license snips
MrStevns 255f631
Fix tests crashing
MrStevns 5cdf342
Add missing MOC for backupmanager for Qt 6 compatibility
MrStevns a52e346
Change argument type for layer bitmap/vector
MrStevns 57e3919
Calling backupmanager backup should be noop for when not activated
MrStevns 9688f4a
Fix vector selection not being painted immediately during undo/redo
MrStevns d034b64
Simplify CanvasPainter::paintCurrentFrame logic
MrStevns 12a5cfc
Merge branch 'delayed-vector-transformation' into undo-redo-manager-v2
MrStevns 4732037
Fix rotation would jump when using undo/redo and trying to modify again
MrStevns 291dc04
Merge branch 'bug-selection-rotation-offset' into undo-redo-manager-v2
MrStevns 192eba9
Re-enable selection backups
MrStevns 8bf0866
Do some spring cleaning in BackupManager
MrStevns 380ab00
Merge branch 'master' into undo-redo-manager-v2
MrStevns c370430
Remove use of ptr's, so we don't have to deal with memory freeing.
MrStevns b4dcd3b
Remove redundant member variables
MrStevns bcbee06
Replace replaceLastFoo in favour of a generic replaceKeyFrame method
MrStevns 6a1375c
Fix some issues and housekeeping etc.
J5lx 67d9596
Attempt to fix CI-only build failure
J5lx 822de83
Merge pull request #22 from J5lx/MrStevns/undo-redo-manager-v2
MrStevns e3a9e4b
Fix legacy undo/redo actions being enabled following startup
J5lx 64fbbcf
Remove superfluous delete
J5lx dc5d40c
Fix undo/redo system being broken
MrStevns 30c6275
Remove redundant methods in backupelement
MrStevns 4fbbc13
Remove id in backupelement
MrStevns e968d49
Add unreachable check to TransformElement
MrStevns d5291fa
Use QUndoStack clean instead if checking the backupElement ptr
MrStevns 378d378
Refactor replaceKeyFrame, should use getXAtFrame instead of getLast
MrStevns 1e47ec3
Prevent use of a saved undo state more than once
MrStevns 5ef8398
Rename BackupElements -> old/new to undo/redo
MrStevns 8364074
Refactor Backup terminology to UndoCommand terminology
MrStevns 79ec18b
Remove undo/redo prefix when using new undo/redo system
MrStevns 1857aae
TransformCommand: split undo/redo keyframe resolving
MrStevns 55f2001
Fix old backupmanager references
MrStevns 5da7bf6
Implement ability to set undo/redo steps
MrStevns 71263a8
Merge remote-tracking branch 'pencil2d/master' into undo-redo-manager-v2
MrStevns 1aef143
Change QUndoStack from ptr to object
MrStevns d107fce
Update core_lib/src/managers/undoredomanager.cpp
MrStevns c3ed826
Update app/src/generalpage.cpp
MrStevns 7d63d35
Update app/ui/generalpage.ui
MrStevns b043dd1
Fix changes individual undo/redo setting would disable buttons.
MrStevns b55228c
Add newline for easier readability
MrStevns 40be1e0
Rework how undo save state should be used
MrStevns 2090e69
Simplify UndoRedoManager::add
MrStevns 97f50f2
Update core_lib/src/managers/undoredomanager.cpp
MrStevns c795dc8
Fix transform command children would not be called the first time
MrStevns e629e9c
Rename Undo commands to be more specific
MrStevns bdd92fd
Rewrite how state is recorded and saved temporarily.
MrStevns 08fbc40
Rename saveStates -> state
MrStevns 5f549c7
Use layerType from save state rather than current layer
MrStevns 7dac960
UndoRedoManager: Improve assert description
MrStevns c88fb54
Merge branch 'master' into undo-redo-manager-v2
chchwy ae65a13
Merge remote-tracking branch 'pencil2d/master' into undo-redo-manager-v2
MrStevns a10d2da
Merge remote-tracking branch 'pencil2d/master' into undo-redo-manager-v2
MrStevns bab3f1e
Merge branch 'master' into undo-redo-manager-v2
MrStevns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB const for scalar parameters is only relevant in the definition and meaningless in the declaration.