Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new Undo/Redo system #1817

Merged
merged 65 commits into from
Sep 6, 2024
Merged

Introduce new Undo/Redo system #1817

merged 65 commits into from
Sep 6, 2024

Commits on Apr 1, 2024

  1. Implement ability to switch between old and new backup system

    @MrStevns
    MrStevns committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    d291117 View commit details
    Browse the repository at this point in the history

  2. Remove anything but the most essential logic

    @MrStevns
    MrStevns committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e755311 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Make it more obvious that we're calling the legacy system

    @MrStevns
    MrStevns committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0bc7331 View commit details
    Browse the repository at this point in the history

  2. Make sure we always update the save counter

    @MrStevns
    MrStevns committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e9ef704 View commit details
    Browse the repository at this point in the history

  3. Change feature dialog text

    @MrStevns
    MrStevns committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c685bc7 View commit details
    Browse the repository at this point in the history

  4. Add another dialog when re-enabling the old system

    @MrStevns
    MrStevns committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d381cdf View commit details
    Browse the repository at this point in the history

  5. Apply more cleanup before restructuring

    @MrStevns
    MrStevns committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    849e4a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Refactor backupManager

    @MrStevns
    MrStevns committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c41802a View commit details
    Browse the repository at this point in the history

  2. Introduce the new backup system to stroke tools and polyline. 

    Also add a guard to make sure that saveStates doesn't do anything while we use the old system.
    @MrStevns
    MrStevns committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    aa12b52 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Add backup for smudge tool

    @MrStevns
    MrStevns committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f9c93a2 View commit details
    Browse the repository at this point in the history

  2. Remove commented code

    @MrStevns
    MrStevns committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    28df936 View commit details
    Browse the repository at this point in the history

  3. Update license snips

    @MrStevns
    MrStevns committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    cb30ce6 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Fix tests crashing

    @MrStevns
    MrStevns committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    255f631 View commit details
    Browse the repository at this point in the history

  2. Add missing MOC for backupmanager for Qt 6 compatibility 

    Also removed an unused reference
    @MrStevns
    MrStevns committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5cdf342 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Change argument type for layer bitmap/vector

    @MrStevns
    MrStevns committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a52e346 View commit details
    Browse the repository at this point in the history

  2. Calling backupmanager backup should be noop for when not activated

    @MrStevns
    MrStevns committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    57e3919 View commit details
    Browse the repository at this point in the history

  3. Fix vector selection not being painted immediately during undo/redo

    @MrStevns
    MrStevns committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9688f4a View commit details
    Browse the repository at this point in the history

  4. Simplify CanvasPainter::paintCurrentFrame logic 

    Since we're always drawing the backbuffer, the logic gates are redundant.
    @MrStevns
    MrStevns committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d034b64 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'delayed-vector-transformation' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    12a5cfc View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Fix rotation would jump when using undo/redo and trying to modify again

    @MrStevns
    MrStevns committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4732037 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bug-selection-rotation-offset' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    291dc04 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Re-enable selection backups

    @MrStevns
    MrStevns committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    192eba9 View commit details
    Browse the repository at this point in the history

  2. Do some spring cleaning in BackupManager

    @MrStevns
    MrStevns committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8bf0866 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Merge branch 'master' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    380ab00 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Remove use of ptr's, so we don't have to deal with memory freeing.

    @MrStevns
    MrStevns committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c370430 View commit details
    Browse the repository at this point in the history

  2. Remove redundant member variables 

    Since the keyframe already contains the frame pos, there's no reason to keep a second value which could lead to bugs in the future.
    @MrStevns
    MrStevns committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b4dcd3b View commit details
    Browse the repository at this point in the history

  3. Replace replaceLastFoo in favour of a generic replaceKeyFrame method

    @MrStevns
    MrStevns committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bcbee06 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Fix some issues and housekeeping etc.

    @J5lx
    J5lx committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6a1375c View commit details
    Browse the repository at this point in the history

  2. Attempt to fix CI-only build failure

    @J5lx
    J5lx committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    67d9596 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #22 from J5lx/MrStevns/undo-redo-manager-v2 

    Fix some issues and housekeeping etc.
    @MrStevns
    MrStevns authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    822de83 View commit details
    Browse the repository at this point in the history

  4. Fix legacy undo/redo actions being enabled following startup

    @J5lx
    J5lx committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e3a9e4b View commit details
    Browse the repository at this point in the history

  5. Remove superfluous delete

    @J5lx
    J5lx committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    64fbbcf View commit details
    Browse the repository at this point in the history

  6. Fix undo/redo system being broken 

    Caused by a brainfart in the evening...
    @MrStevns
    MrStevns committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    dc5d40c View commit details
    Browse the repository at this point in the history

  7. Remove redundant methods in backupelement

    @MrStevns
    MrStevns committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    30c6275 View commit details
    Browse the repository at this point in the history

  8. Remove id in backupelement 

    Used for compressing backup events, which is currently not implemented.
    @MrStevns
    MrStevns committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4fbbc13 View commit details
    Browse the repository at this point in the history

  9. Add unreachable check to TransformElement

    @MrStevns
    MrStevns committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e968d49 View commit details
    Browse the repository at this point in the history

  10. Use QUndoStack clean instead if checking the backupElement ptr

    @MrStevns
    MrStevns committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d5291fa View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Refactor replaceKeyFrame, should use getXAtFrame instead of getLast

    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    378d378 View commit details
    Browse the repository at this point in the history

  2. Prevent use of a saved undo state more than once 

    Also fixed memory leak situation with clone not being cleaned up later.
    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1e47ec3 View commit details
    Browse the repository at this point in the history

  3. Rename BackupElements -> old/new to undo/redo

    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5ef8398 View commit details
    Browse the repository at this point in the history

  4. Refactor Backup terminology to UndoCommand terminology

    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8364074 View commit details
    Browse the repository at this point in the history

  5. Remove undo/redo prefix when using new undo/redo system

    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    79ec18b View commit details
    Browse the repository at this point in the history

  6. TransformCommand: split undo/redo keyframe resolving

    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1857aae View commit details
    Browse the repository at this point in the history

  7. Fix old backupmanager references

    @MrStevns
    MrStevns committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    55f2001 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Implement ability to set undo/redo steps 

    And set default to 100 steps.
    @MrStevns
    MrStevns committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5da7bf6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'pencil2d/master' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    71263a8 View commit details
    Browse the repository at this point in the history

  3. Change QUndoStack from ptr to object

    @MrStevns
    MrStevns committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1aef143 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Update core_lib/src/managers/undoredomanager.cpp 

    Co-authored-by: Jakob <[email protected]>
    @MrStevns @J5lx
    MrStevns and J5lx authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d107fce View commit details
    Browse the repository at this point in the history

  2. Update app/src/generalpage.cpp 

    Co-authored-by: Jakob <[email protected]>
    @MrStevns @J5lx
    MrStevns and J5lx authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c3ed826 View commit details
    Browse the repository at this point in the history

  3. Update app/ui/generalpage.ui 

    Co-authored-by: Jakob <[email protected]>
    @MrStevns @J5lx
    MrStevns and J5lx authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7d63d35 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Fix changes individual undo/redo setting would disable buttons.

    @MrStevns
    MrStevns committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b043dd1 View commit details
    Browse the repository at this point in the history

  2. Add newline for easier readability

    @MrStevns
    MrStevns committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b55228c View commit details
    Browse the repository at this point in the history

  3. Rework how undo save state should be used 

    It's no longer possible to call add without having a valid save state. This makes it easier to see where the state comes from as well as allowing you to keep multiple save states at the same time.
    @MrStevns
    MrStevns committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    40be1e0 View commit details
    Browse the repository at this point in the history

  4. Simplify UndoRedoManager::add

    @MrStevns
    MrStevns committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    2090e69 View commit details
    Browse the repository at this point in the history

  5. Update core_lib/src/managers/undoredomanager.cpp 

    Co-authored-by: Jakob <[email protected]>
    @MrStevns @J5lx
    MrStevns and J5lx authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    97f50f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Fix transform command children would not be called the first time 

    Which resulted in isFirstRedo being ignored
    @MrStevns
    MrStevns committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c795dc8 View commit details
    Browse the repository at this point in the history

  2. Rename Undo commands to be more specific

    @MrStevns
    MrStevns committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e629e9c View commit details
    Browse the repository at this point in the history

  3. Rewrite how state is recorded and saved temporarily.

    @MrStevns
    MrStevns committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    bdd92fd View commit details
    Browse the repository at this point in the history

  4. Rename saveStates -> state

    @MrStevns
    MrStevns committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    08fbc40 View commit details
    Browse the repository at this point in the history

  5. Use layerType from save state rather than current layer

    @MrStevns
    MrStevns committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5f549c7 View commit details
    Browse the repository at this point in the history

  6. UndoRedoManager: Improve assert description

    @MrStevns
    MrStevns committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7dac960 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'master' into undo-redo-manager-v2

    @chchwy
    chchwy authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c88fb54 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Merge remote-tracking branch 'pencil2d/master' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ae65a13 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'pencil2d/master' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a10d2da View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Merge branch 'master' into undo-redo-manager-v2

    @MrStevns
    MrStevns committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    bab3f1e View commit details
    Browse the repository at this point in the history