-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI icons re-design #1361
UI icons re-design #1361
Conversation
You can download the branch yourself ( |
…row-x icons, reorganize the tools icons
…in, and soundscrub, increasing size of controls icons.
- We now have classic, legacy and playful - Playful icons has been optimized and tweaked. - Move icons into theme folders I should have done the move separately but well... I forgot! and now it's done P:
At long last, this PR is ready to be reviewed! What are your thoughts on keeping the old icons?
although we're currently using a combination of Legacy and Classic icons, I still thought it made sense to separate them. Should we keep or remove them? Thanks to @Fatih20 for starting this re-design, hopefully my involvement and the changes I've made during the lifetime of this PR, hasn't made you less proud of what you started and achieved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn’t come as too much of a surprise after the discussion in the linked issue, but I’m already very satisfied with the state of this PR. Just a handful of small remarks at this point. Thanks for all the hard work on this!
What are your thoughts on keeping the old icons?
I think we should delete them. Should we ever have need of them again, we can simply recover them from git history.
Bundling or Download?I like the idea of modular theme packs. Are we hosting them separately in the github repo tho? or are we bundling them with Pencil2D. We could either bundle classic & "playful", leaving legacy as an optional download (Github). However I recall back then, when the original icons were changed some people did lament the icon changes. It might happen again so it could be simpler to bundle them 🤔 One minor issueThere's only one think I didn't know If I should say, but It still bothers me, and it's the hand & finger icons in the playful version. I simply never liked it from the start. If anyone reads the conversation, I tried to nudge the OP into changing the initial version, which he agreed to, but it was never possible to come to final solution after the project was halted. The reasons are many but mostly I want to change the shape, proportion, anatomy and visual clarity by simplifying the details both have. In that sense the Classic ones are more readable. How to contribute to the icon packs?Right now I don't have the time to change it, but I'll ask for reference: If I did change the SVGs, would that be easily replaced in the icon bundle via PR to contribute a potential change? Additionally how would themes / packs work? I think with this we should consider at least some minor form of documentation so we can provide that to our users 🤔 Thank youOther than that everything looks very vibrant and focused, so I think you did a great job taking over the overall project. Thank you 🙇♂️ |
Just to be clear, there are no theme packs in this PR. Oliver only organised the icons into folders within the repository so that we could potentially add theme packs in the future, but right now the icon paths used by the program are still hard-coded. Theme packs are a distinct feature which is out-of-scope for this PR. |
Thanks for the help, I appreciate it 🙇 Meanwhile in order to not stall the PR further as you say, we'll let Jakob continue his review and merge the PR when it's done. I'll then create a second PR later to continue the work on hand and smudge icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the remarks from my previous review all addressed, I don’t think I have much else to add. If anything, perhaps it would make sense to flip the zoom icons so the little overlay +/- is in the same corner as the layer/frame management icons. But as you say, maybe it is time to just merge this and make separate PRs for further improvements. So if no one else has anything to add, I think it’s fine to merge this.
What about the removal of the old icons, though? As I said before, I don’t think it’s worth keeping them around if we’re not going to use them anymore. If we do need them again, we can retrieve them from git history.
Adjusted from 7x7px to 10x10 since that is what other overlays are
The placement was deliberate as the overlays would obscure almost the entire handle, which is imo. important to decipher the icons properly. I did end up making the overlays slightly bigger though.
Good point. I've removed them now. |
My original thought was to flip the icons… but on second thought, maybe that would be a bit unusual because it would suggest left-handed usage… |
I considered it but decided against it for the reason that the majority of magnifier icons I could find were turned to the left rather than right. |
With Jose being onboard with the redesigned hand and smudge icons, and Jacob having reviewed the PR, I will merge the PR 🎉 |
All of the icons have been redesigned (needed to be refined and still prone to changes).
All of the icons name have been standardized.
x-y
instead ofxY
orx_y
All of the icons have been compartmentalized into folders.
closes #1356